Skip to content

Commit c371efe

Browse files
committed
Remove failing @ts-expect-error in test
1 parent 7486150 commit c371efe

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

integration/templates/next-app-router/src/app/transitions/page.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@ function TransitionController() {
7272
(promise as any).resolve = resolve;
7373
setTransitionPromise(promise);
7474

75-
// Async transition functions were introduced in React 19, but test outcome is the same regardless
76-
// @ts-expect-error
7775
startTransition(async () => {
7876
await promise;
7977
});
@@ -117,8 +115,6 @@ function TransitionSwitcherButton({
117115
return (
118116
<button
119117
onClick={() => {
120-
// Async transition functions were introduced in React 19, but test outcome is the same regardless
121-
// @ts-expect-error
122118
startTransition(async () => {
123119
// Note that this does not currently work, as setActive does not support transitions,
124120
// we are using it to verify the existing behavior.

packages/shared/src/react/hooks/base/useClientBase.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import type { ClientResource } from '@/types';
55
import { useClerkInstanceContext } from '../../contexts';
66

77
const initialSnapshot = undefined;
8+
const getInitialSnapshot = () => initialSnapshot;
89
export function useClientBase(): ClientResource | null | undefined {
910
const clerk = useClerkInstanceContext();
1011

@@ -15,8 +16,8 @@ export function useClientBase(): ClientResource | null | undefined {
1516
return initialSnapshot;
1617
}
1718
return clerk.client;
18-
}, [clerk.client, initialSnapshot, clerk.loaded]),
19-
useCallback(() => initialSnapshot, []),
19+
}, [clerk]),
20+
getInitialSnapshot,
2021
);
2122

2223
return client;

packages/shared/src/react/hooks/base/useSessionBase.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ import { useClerkInstanceContext, useInitialStateContext } from '../../contexts'
77
export function useSessionBase(): SignedInSessionResource | null | undefined {
88
const clerk = useClerkInstanceContext();
99
const initialState = useInitialStateContext();
10-
const getInitialState = useCallback(() => initialState?.session as SignedInSessionResource, [initialState?.session]);
10+
const getInitialState = useCallback(() => {
11+
return initialState?.session as SignedInSessionResource | undefined;
12+
}, [initialState?.session]);
1113

1214
const session = useSyncExternalStore(
1315
useCallback(callback => clerk.addListener(callback, { skipInitialEmit: true }), [clerk]),

0 commit comments

Comments
 (0)