Revert "fix(clerk-js): If password is enabled, instanceIsPasswordBased is true (#6599)" (#6643)

Author: dmoerner

.changeset/khaki-ravens-cheer.md

@@ -0,0 +1,2 @@
+---
+---

.changeset/lemon-paths-brake.md

@@ -191,7 +191,7 @@ export class UserSettings extends BaseResource implements UserSettingsResource {
   }
 
   get instanceIsPasswordBased() {
-    return Boolean(this.attributes?.password?.enabled);
+    return Boolean(this.attributes?.password?.enabled && this.attributes.password?.required);
   }
 
   get hasValidAuthFactor() {

packages/clerk-js/src/core/resources/UserSettings.ts

@@ -75,18 +75,6 @@ describe('UserSettings', () => {
         },
       },
     } as any as UserSettingsJSON);
-
-    expect(sut.instanceIsPasswordBased).toEqual(true);
-
-    sut = new UserSettings({
-      attributes: {
-        password: {
-          enabled: false,
-          required: false,
-        },
-      },
-    } as any as UserSettingsJSON);
-
     expect(sut.instanceIsPasswordBased).toEqual(false);
   });
 

packages/clerk-js/src/core/resources/__tests__/UserSettings.spec.ts

@@ -476,7 +476,7 @@ describe('SignInStart', () => {
       it(`calls sign in with identifier again with only the email if the api respondes with the error ${code}`, async () => {
         const { wrapper, fixtures } = await createFixtures(f => {
           f.withEmailAddress();
-          f.withPassword();
+          f.withPassword({ required: true });
         });
 
         const errJSON = {

packages/clerk-js/src/ui/components/SignIn/__tests__/SignInStart.test.tsx

@@ -32,7 +32,9 @@ describe('SecurityPage', () => {
 
   it('renders the Password section if instance is password based', async () => {
     const { wrapper, fixtures } = await createFixtures(f => {
-      f.withPassword();
+      f.withPassword({
+        required: true,
+      });
       f.withUser({ email_addresses: ['[email protected]'] });
     });
     fixtures.clerk.user?.getSessions.mockReturnValue(Promise.resolve([]));