Add warning for missing params for task handling

Author: LauraBeatris

packages/clerk-js/src/core/clerk.ts

@@ -151,7 +151,7 @@ import {
   Organization,
   Waitlist,
 } from './resources/internal';
-import { navigateIfTaskExists } from './sessionTasks';
+import { navigateIfTaskExists, warnMissingPendingTaskHandlers } from './sessionTasks';
 import { State } from './state';
 import { warnings } from './warnings';
 
@@ -1231,6 +1231,10 @@ export class Clerk implements ClerkInterface {
       let newSession = session === undefined ? this.session : session;
       const sessionIsPending = newSession?.status === 'pending';
 
+      if (sessionIsPending) {
+        warnMissingPendingTaskHandlers(params);
+      }
+
       // At this point, the `session` variable should contain either an `SignedInSessionResource`
       // ,`null` or `undefined`.
       // We now want to set the last active organization id on that session (if it exists).

packages/clerk-js/src/core/sessionTasks.ts

@@ -1,4 +1,5 @@
-import type { SessionResource, SessionTask } from '@clerk/types';
+import { logger } from '@clerk/shared/logger';
+import type { ClerkOptions, SessionResource, SessionTask, SetActiveParams } from '@clerk/types';
 
 import { buildURL } from '../utils';
 
@@ -42,3 +43,19 @@ export function navigateIfTaskExists(
 
   return navigate(buildTaskURL(currentTask, { base: baseUrl }));
 }
+
+export function warnMissingPendingTaskHandlers(options: Record<string, unknown>) {
+  const taskOptions = ['taskUrls', 'navigate'] as Array<
+    keyof (Pick<SetActiveParams, 'navigate'> & Pick<ClerkOptions, 'taskUrls'>)
+  >;
+
+  const hasAtLeastOneTaskOption = Object.keys(options).some(option => taskOptions.includes(option as any));
+  if (hasAtLeastOneTaskOption) {
+    return;
+  }
+
+  // TODO - Link to after-auth docs once it gets released
+  logger.warnOnce(
+    `Clerk: Session has pending tasks but no handling is configured. To handle pending tasks automatically, provide either "taskUrls" for navigation to custom URLs or "navigate" for programmatic navigation. Without these options, users may get stuck on incomplete flows.`,
+  );
+}

packages/clerk-js/src/utils/assertNoLegacyProp.ts

@@ -1,5 +1,4 @@
 import { logger } from '@clerk/shared/logger';
-import type { ClerkOptions } from '@clerk/types';
 
 export function assertNoLegacyProp(props: Record<string, any>) {
   const legacyProps = ['redirectUrl', 'afterSignInUrl', 'afterSignUpUrl', 'after_sign_in_url', 'after_sign_up_url'];
@@ -24,17 +23,3 @@ export function warnForNewPropShadowingLegacyProp(
     );
   }
 }
-
-export function warnNoTaskOptions(options: ClerkOptions) {
-  const taskOptions = ['taskUrls', 'onPendingSession'];
-
-  const hasAtLeastOneTaskOption = Object.keys(options).some(option => taskOptions.includes(option));
-  if (hasAtLeastOneTaskOption) {
-    return;
-  }
-
-  logger.warnOnce(
-    // TODO - Link to after-auth docs once it gets released
-    `Clerk: After-auth is enabled and no task options configured. Consider providing "taskUrls" or "onPendingSession" to handle pending session tasks.`,
-  );
-}