Skip to content

Commit eea8ce0

Browse files
wobsorianoLekoArts
andauthored
Revert "fix(tanstack-start): Fix event handler return type mismatch" (#5068)
Co-authored-by: Lennart <lekoarts@gmail.com>
1 parent bbb4ef7 commit eea8ce0

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

.changeset/quiet-ties-walk.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@clerk/tanstack-start": patch
3+
---
4+
5+
Reverts [#5051](https://github.com/clerk/javascript/pull/5051)
6+
7+
This type change is no longer needed as the underlying `h3` version compatibility issue has been resolved upstream in the TanStack Router repository ([TanStack/router#3310](https://github.com/TanStack/router/pull/3310))

packages/tanstack-start/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,7 @@
6969
"devDependencies": {
7070
"@tanstack/react-router": "^1.97.25",
7171
"@tanstack/start": "^1.97.25",
72-
"esbuild-plugin-file-path-extensions": "^2.1.2",
73-
"h3": "^1.13.0"
72+
"esbuild-plugin-file-path-extensions": "^2.1.2"
7473
},
7574
"peerDependencies": {
7675
"@tanstack/react-router": ">=1.85.9",

packages/tanstack-start/src/server/middlewareHandler.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { AnyRouter } from '@tanstack/react-router';
2-
import type { eventHandler } from 'h3';
2+
import type { EventHandler } from 'vinxi/http';
33

44
import { authenticateRequest } from './authenticateRequest';
55
import { loadOptions } from './loadOptions';
@@ -11,16 +11,13 @@ export type HandlerCallback<TRouter extends AnyRouter> = (ctx: {
1111
router: TRouter;
1212
responseHeaders: Headers;
1313
}) => Response | Promise<Response>;
14-
15-
export type CustomizeStartHandler<TRouter extends AnyRouter> = (
16-
cb: HandlerCallback<TRouter>,
17-
) => ReturnType<typeof eventHandler>;
14+
export type CustomizeStartHandler<TRouter extends AnyRouter> = (cb: HandlerCallback<TRouter>) => EventHandler;
1815

1916
export function createClerkHandler<TRouter extends AnyRouter>(
2017
eventHandler: CustomizeStartHandler<TRouter>,
2118
clerkOptions: LoaderOptions = {},
2219
) {
23-
return (cb: HandlerCallback<TRouter>) => {
20+
return (cb: HandlerCallback<TRouter>): EventHandler => {
2421
return eventHandler(async ({ request, router, responseHeaders }) => {
2522
try {
2623
const loadedOptions = loadOptions(request, clerkOptions);

pnpm-lock.yaml

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)