chore(repo): Align method prefixes, remove unused unstable methods#7361
Conversation
🦋 Changeset detectedLatest commit: 0f83c0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
!allow-major |
| - `__unstable_manageBillingUrl` (removed) | ||
| - `__unstable_manageBillingLabel` (removed) | ||
| - `__unstable_manageBillingMembersLimit` (removed) |
There was a problem hiding this comment.
As far as I can tell, these are unused and were to support Dashboard's use of our orgs components a few years ago
| - `__unstable_manageBillingUrl` (removed) | ||
| - `__unstable_manageBillingLabel` (removed) | ||
| - `__unstable_manageBillingMembersLimit` (removed) | ||
| - `experimental__forceOauthFirst` (removed) |
There was a problem hiding this comment.
Underlying properties on the API response object were removed in core 2, so finishing the cleanup here
| - `experimental_createTheme` / `__experimental_createTheme` → `createTheme` (now exported from `@clerk/ui/themes/experimental`) | ||
| - `experimental__simple` / `__experimental_simple` → `simple` (now exported from `@clerk/ui/themes/experimental`) |
There was a problem hiding this comment.
Moving to the preferred /experimental export pattern
| - `experimental__simple` / `__experimental_simple` → `simple` (now exported from `@clerk/ui/themes/experimental`) | ||
|
|
||
| ### @clerk/chrome-extension | ||
| - `__unstable__createClerkClient` → `createClerkClient` (exported from `@clerk/chrome-extension/background`) |
There was a problem hiding this comment.
I'm not sure if this should remain experimental/internal 🤔 @tmilewski do you have context?
There was a problem hiding this comment.
@brkalow Yeah, this can be moved to stable at this point.
| ### Experimental and internal APIs | ||
|
|
||
| In some cases, we might need to add new methods to our publicly exposed APIs that are meant for internal use, or as experimental releases before the APIs are stabilized. For internal methods or properties, use the `__internal_` prefix. For experimental methods or properties that are attached to existing APIs, use the `__experimental_` prefix. For new exports, it is also acceptable to export from an `/experimental` subpath. Exports from `/experimental` are not covered by regular SemVer guarantees. |
| }, | ||
| }; | ||
|
|
||
| const noUnstableMethods = { |
There was a problem hiding this comment.
New ESLint rule that should hopefully avoid any accidental addition of __unstable_ prefixes
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
!allow-major |
Description
__unstable_naming patternChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change