-
Notifications
You must be signed in to change notification settings - Fork 430
fix(ui): Handle unsafeMetadata in ticket flows
#7660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): Handle unsafeMetadata in ticket flows
#7660
Conversation
🦋 Changeset detectedLatest commit: 1e9a2ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughA new changeset file (.changeset/heavy-parrots-juggle.md) was added. The SignUpStart.tsx component now includes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
unsafeMetadata in ticket flows
jacekradko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a changeset update
Co-authored-by: Jacek Radko <jacek@clerk.dev>
Co-authored-by: Jacek Radko <jacek@clerk.dev>
Description
Port of Core 2 changes: #7657
Summary
Fixes a bug where
unsafeMetadatawas not being passed tosignUp.create()when users sign up via the ticket/invitation flow. This caused users created through invitation links to have emptyunsafeMetadata, even when it was configured on the<SignUp>component.Problem
When a user signs up using a ticket (e.g., from an invitation link), the
handleTokenFlowfunction inSignUpStart.tsxwas callingsignUp.create()without includingunsafeMetadata. This is inconsistent with other sign-up flows (OAuth, Web3, manual form submission) which all correctly passunsafeMetadata.Solution
Updated
handleTokenFlowto includeunsafeMetadatain thesignUp.create()call. TheunsafeMetadatavalue is already available from the component context, so we simply pass it through.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Bug Fixes
Tests
✏️ Tip: You can customize this high-level summary in your review settings.