-
Notifications
You must be signed in to change notification settings - Fork 431
fix(repo): Trigger workflow dispatch after npm publish succeeds #7684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The workflow dispatch was triggering based on version-packages success, not on whether the actual npm publish completed successfully. This change ensures downstream workflows are only triggered after pnpm release:canary finishes.
🦋 Changeset detectedLatest commit: 70bc6bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
📝 WalkthroughWalkthroughThe change updates the Canary release workflow in the GitHub Actions configuration. A new step with id 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Summary
steps.version-packages.outputs.success, which only verified that versioning succeeded, not that the actual npm publish completedsteps.publish.outcome == 'success', ensuring downstream workflows only trigger after packages are publishedTest plan
pnpm release:canarysucceedsSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.