Skip to content

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Jan 27, 2026

Summary

  • Fixed the canary release workflow to only trigger downstream workflow dispatches after the npm publish step completes successfully
  • Previously, the dispatch condition checked steps.version-packages.outputs.success, which only verified that versioning succeeded, not that the actual npm publish completed
  • Now the dispatch condition checks steps.publish.outcome == 'success', ensuring downstream workflows only trigger after packages are published

Test plan

  • Verify the canary release workflow triggers dispatches only after pnpm release:canary succeeds
  • Confirm that if the publish step fails, no workflow dispatches are triggered

Summary by CodeRabbit

  • Chores
    • Updated canary release workflow to add an explicit publish step and adjust conditional triggers so downstream steps run based on that publish result.
    • Added a placeholder changeset file (no runtime or public API changes).

✏️ Tip: You can customize this high-level summary in your review settings.

The workflow dispatch was triggering based on version-packages success,
not on whether the actual npm publish completed successfully. This change
ensures downstream workflows are only triggered after pnpm release:canary
finishes.
@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: 70bc6bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jan 27, 2026 0:30am

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 27, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7684

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7684

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7684

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7684

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7684

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7684

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7684

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7684

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7684

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7684

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7684

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7684

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7684

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7684

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7684

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7684

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7684

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7684

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7684

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7684

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7684

commit: 70bc6bb

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

The change updates the Canary release workflow in the GitHub Actions configuration. A new step with id publish has been added to the release sequence. The conditional for the "Trigger workflows on related repos" step was changed to depend on the outcome of the publish step instead of the version-packages step's success status. Additionally, a new changeset file .changeset/young-rings-wear.md containing two lines of --- was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the canary workflow to trigger downstream workflow dispatches after npm publish succeeds, which aligns with the changeset modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jacekradko jacekradko merged commit 9fdb021 into main Jan 27, 2026
40 checks passed
@jacekradko jacekradko deleted the jr/fix-canary-workflow-dispatch-timing branch January 27, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants