-
Notifications
You must be signed in to change notification settings - Fork 431
fix(ci): prevent nightly tests from using npm stable instead of verdaccio snapshot #7697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ccio snapshot The nightly tests were failing because they installed @clerk/[email protected] (stable) instead of the locally-built snapshot packages from verdaccio. Root cause: - verdaccio.install.yaml had `proxy: npmjs` for @clerk/* packages - Snapshot packages don't have a "latest" dist-tag - When tests requested "latest", verdaccio proxied to npm, returning stable 6.x - Stable doesn't have the Show component (v7 only), causing import errors Changes: - Remove proxy for @clerk/* in verdaccio.install.yaml to prevent npm fallback - Remove E2E_CLERK_JS_VERSION from nightly workflow to use '*' instead of 'latest'
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: f175a95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughAdded a new empty changeset file and updated CI and registry configs. The nightly-checks workflow gained a "Version packages for snapshot" step, verdaccio publish now uses the latest tag, and explicit environment variables for the JS and UI e2e packages were replaced by comments/wildcard linkPackage usage; multi-line pnpm install/init scripts were introduced. The verdaccio registry config removed the proxy setting for clerk/* packages. A public package entry (clerk/types) was removed from a CI action and its dependency was removed from the nuxt integration preset. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
- Add version-packages:snapshot step before verdaccio publish - Add --tag latest to changeset publish command - Add pnpm config set minimum-release-age-exclude @clerk/* before installs - Fix npm -> pnpm in registry check These changes align nightly workflow with ci.yml workflow configuration.
Summary
Fixes nightly e2e test failures where tests were getting
@clerk/[email protected](stable) instead of locally-built snapshot packages from verdaccio.Root Cause:
verdaccio.install.yamlhadproxy: npmjsfor@clerk/*packages@clerk/nextjs@latest, verdaccio couldn't find it locally and proxied to npmShowcomponent (v7 only)Changes:
proxy: npmjsfor@clerk/*inverdaccio.install.yamlto prevent npm fallbackE2E_CLERK_JS_VERSION: "latest"from nightly workflow to use'*'(vialinkPackage()) which matches any version including snapshotsTest plan
Showcomponent import should resolve correctly with the v7 snapshotSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.