Skip to content

Conversation

@jacekradko
Copy link
Member

@jacekradko jacekradko commented Jan 28, 2026

Summary

Fixes nightly e2e test failures where tests were getting @clerk/[email protected] (stable) instead of locally-built snapshot packages from verdaccio.

Root Cause:

  • verdaccio.install.yaml had proxy: npmjs for @clerk/* packages
  • Snapshot packages are published with snapshot dist-tags, not "latest"
  • When tests requested @clerk/nextjs@latest, verdaccio couldn't find it locally and proxied to npm
  • npm returned stable 6.x which doesn't have the Show component (v7 only)
  • This caused the misleading error: "Export Show doesn't exist in target module"

Changes:

  • Remove proxy: npmjs for @clerk/* in verdaccio.install.yaml to prevent npm fallback
  • Remove E2E_CLERK_JS_VERSION: "latest" from nightly workflow to use '*' (via linkPackage()) which matches any version including snapshots

Test plan

  • Nightly workflow should now correctly use snapshot packages from verdaccio
  • The Show component import should resolve correctly with the v7 snapshot

Summary by CodeRabbit

  • Chores
    • Updated CI workflows and snapshot/versioning steps to improve build consistency and snapshot testing.
    • Adjusted local registry and publish settings to ensure locally published packages are used during testing.
    • Removed an unused package from internal publish/version reporting and from a test preset dependency graph.
    • Minor integration and environment variable handling tweaks; no user-facing changes.

✏️ Tip: You can customize this high-level summary in your review settings.

…ccio snapshot

The nightly tests were failing because they installed @clerk/[email protected] (stable)
instead of the locally-built snapshot packages from verdaccio.

Root cause:
- verdaccio.install.yaml had `proxy: npmjs` for @clerk/* packages
- Snapshot packages don't have a "latest" dist-tag
- When tests requested "latest", verdaccio proxied to npm, returning stable 6.x
- Stable doesn't have the Show component (v7 only), causing import errors

Changes:
- Remove proxy for @clerk/* in verdaccio.install.yaml to prevent npm fallback
- Remove E2E_CLERK_JS_VERSION from nightly workflow to use '*' instead of 'latest'
@vercel
Copy link

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jan 29, 2026 1:42am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2026

🦋 Changeset detected

Latest commit: f175a95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Added a new empty changeset file and updated CI and registry configs. The nightly-checks workflow gained a "Version packages for snapshot" step, verdaccio publish now uses the latest tag, and explicit environment variables for the JS and UI e2e packages were replaced by comments/wildcard linkPackage usage; multi-line pnpm install/init scripts were introduced. The verdaccio registry config removed the proxy setting for clerk/* packages. A public package entry (clerk/types) was removed from a CI action and its dependency was removed from the nuxt integration preset.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main fix: preventing nightly tests from using npm stable instead of verdaccio snapshot packages, which directly addresses the root cause described in the PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 28, 2026

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7697

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7697

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7697

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7697

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7697

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7697

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7697

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7697

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7697

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7697

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7697

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7697

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7697

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7697

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7697

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7697

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7697

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7697

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7697

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7697

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7697

commit: f175a95

- Add version-packages:snapshot step before verdaccio publish
- Add --tag latest to changeset publish command
- Add pnpm config set minimum-release-age-exclude @clerk/* before installs
- Fix npm -> pnpm in registry check

These changes align nightly workflow with ci.yml workflow configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants