#11 Push to phpstan level 10

Author: njoubert-cleverage

.php-cs-fixer.dist.php

@@ -35,6 +35,7 @@
         'header_comment' => ['header' => $fileHeaderComment],
         'modernize_strpos' => true,
         'get_class_to_class_keyword' => true,
+        'phpdoc_to_comment' => ['ignored_tags' => ['var']], // Fix issue on initializeStatement method $params variable
     ])
     ->setRiskyAllowed(true)
     ->setFinder(

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 8
+    level: 10
     paths:
         - src
         - tests

src/Task/Database/DatabaseReaderTask.php

@@ -36,7 +36,7 @@
  *      'paginate': ?int,
  *      'offset': ?int,
  *      'input_as_params': bool,
- *      'params': array<int<0, max>|string, mixed>,
+ *      'params': array<string, mixed>,
  *      'types': array<int, int|string|Type|null>|array<string, int|string|Type|null>
  *   }
  */
@@ -137,10 +137,13 @@ protected function initializeStatement(ProcessState $state): Result
             $sql = $qb->getSQL();
         }
 
-        /** @var array<string> $inputAsParams */
         $inputAsParams = $state->getInput();
         $params = $options['input_as_params'] ? $inputAsParams : $options['params'];
+        if (!\is_array($params)) {
+            throw new \UnexpectedValueException('Expecting an array of params');
+        }
 
+        /** @var array<string, mixed> $params */
         return $connection->executeQuery($sql, $params, $options['types']);
     }
 
@@ -186,8 +189,10 @@ protected function configureOptions(OptionsResolver $resolver): void
 
     protected function getConnection(ProcessState $state): Connection
     {
+        /** @var ?string $connectionOptions */
+        $connectionOptions = $this->getOption($state, 'connection');
         /** @var Connection $connection */
-        $connection = $this->doctrine->getConnection($this->getOption($state, 'connection'));
+        $connection = $this->doctrine->getConnection($connectionOptions);
 
         return $connection;
     }

src/Task/Database/DatabaseUpdaterTask.php

@@ -30,7 +30,7 @@
  * @phpstan-type Options array{
  *     'sql': string,
  *     'input_as_params': bool,
- *     'params': mixed,
+ *     'params': array<string, mixed>,
  *     'types': array<int, int|string|Type|null>|array<string, int|string|Type|null>
  * }
  */
@@ -60,13 +60,13 @@ protected function initializeStatement(ProcessState $state): int
         $options = $this->getOptions($state);
         $connection = $this->getConnection($state);
 
-        /** @var array<string> $inputAsParams */
         $inputAsParams = $state->getInput();
         $params = $options['input_as_params'] ? $inputAsParams : $options['params'];
         if (!\is_array($params)) {
             throw new \UnexpectedValueException('Expecting an array of params');
         }
 
+        /** @var array<string, mixed> $params */
         return (int) $connection->executeStatement($options['sql'], $params, $options['types']);
     }
 
@@ -88,8 +88,10 @@ protected function configureOptions(OptionsResolver $resolver): void
 
     protected function getConnection(ProcessState $state): Connection
     {
+        /** @var ?string $connectionOptions */
+        $connectionOptions = $this->getOption($state, 'connection');
         /** @var Connection $connection */
-        $connection = $this->doctrine->getConnection($this->getOption($state, 'connection'));
+        $connection = $this->doctrine->getConnection($connectionOptions);
 
         return $connection;
     }

src/Task/EntityManager/DoctrineBatchWriterTask.php

@@ -34,7 +34,9 @@ public function flush(ProcessState $state): void
 
     public function execute(ProcessState $state): void
     {
-        $this->batch[] = $state->getInput();
+        /** @var object $input */
+        $input = $state->getInput();
+        $this->batch[] = $input;
 
         if (\count($this->batch) >= $this->getOption($state, 'batch_count')) {
             $this->writeBatch($state);