#10 replace uniqid with bin2hex(random_bytes(4)) (like Symfony does)

xaviermarchegay · xaviermarchegay · commit 69e457cfdc33 · 2024-12-10T18:43:26.000+01:00
diff --git a/src/Task/EntityManager/AbstractDoctrineQueryTask.php b/src/Task/EntityManager/AbstractDoctrineQueryTask.php
@@ -68,7 +68,7 @@ protected function getQueryBuilder(
             if (preg_match('/[^a-zA-Z0-9]/', $field)) {
                 throw new \UnexpectedValueException("Forbidden field name '{$field}'");
             }
-            $parameterName = uniqid('param', true);
+            $parameterName = 'param_' . bin2hex(random_bytes(4));
             if (null === $value) {
                 $qb->andWhere("e.{$field} IS null");
             } else {

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ protected function getQueryBuilder(`
`68`	`68`	`if (preg_match('/[^a-zA-Z0-9]/', $field)) {`
`69`	`69`	`throw new \UnexpectedValueException("Forbidden field name '{$field}'");`
`70`	`70`	`}`
`71`		`- $parameterName = uniqid('param', true);`
	`71`	`+ $parameterName = 'param_' . bin2hex(random_bytes(4));`
`72`	`72`	`if (null === $value) {`
`73`	`73`	`$qb->andWhere("e.{$field} IS null");`
`74`	`74`	`} else {`