#148 Update services (step 1) according to Symfony best practices

Author: njoubert-cleverage

config/services/command.yaml

@@ -1,7 +1,27 @@
 services:
-    CleverAge\ProcessBundle\Command\:
-        resource: '../../../Command/*'
-        autowire: true
-        autoconfigure: true
-        bind:
-            $container: '@service_container'
+    cleverage_process.command.execute_process:
+        class: CleverAge\ProcessBundle\Command\ExecuteProcessCommand
+        public: false
+        tags:
+            - { name: console.command }
+        arguments:
+            - '@process_bundle.manager.process'
+            - '@event_dispatcher'
+            - '@process_bundle.registry.process_configuration'
+
+    cleverage_process.command.list_process:
+        class: CleverAge\ProcessBundle\Command\ListProcessCommand
+        public: false
+        tags:
+            - { name: console.command }
+        arguments:
+            - '@process_bundle.registry.process_configuration'
+
+    cleverage_process.command.process_help:
+        class: CleverAge\ProcessBundle\Command\ProcessHelpCommand
+        public: false
+        tags:
+            - { name: console.command }
+        arguments:
+            - '@process_bundle.registry.process_configuration'
+            - '@service_container'

config/services/event.yaml

@@ -1,5 +1,6 @@
 services:
-    CleverAge\ProcessBundle\EventListener\DataQueueEventListener:
+    cleverage_process.event_listener.data_queue:
+        class: CleverAge\ProcessBundle\EventListener\DataQueueEventListener
         public: false
         tags:
             - { name: kernel.event_listener, event: cleverage_process.data_queue, method: pushData }

config/services/expression_language.yaml

@@ -1,9 +1,12 @@
 services:
-    CleverAge\ProcessBundle\ExpressionLanguage\PhpFunctionProvider:
+    cleverage_process.expression_language.php_function_provider:
+        class: CleverAge\ProcessBundle\ExpressionLanguage\PhpFunctionProvider
+        public: false
         arguments:
             - [ 'preg_match' ]
 
     cleverage_process.expression_language:
         class: Symfony\Component\ExpressionLanguage\ExpressionLanguage
+        public: false
         calls:
-            - ['registerProvider', ['@CleverAge\ProcessBundle\ExpressionLanguage\PhpFunctionProvider']]
+            - ['registerProvider', ['@cleverage_process.expression_language.php_function_provider']]

config/services/logger.yaml

@@ -1,25 +1,40 @@
 services:
-    CleverAge\ProcessBundle\Logger\ProcessProcessor:
-        autowire: true
+    cleverage_process.logger.process_processor:
+        class: CleverAge\ProcessBundle\Logger\ProcessProcessor
+        public: false
         tags:
             - { name: monolog.processor, channel: cleverage_process }
+        arguments:
+            - '@process_bundle.manager.process'
 
-    CleverAge\ProcessBundle\Logger\TaskProcessor:
-        autowire: true
+    cleverage_process.logger.task_processor:
+        class: CleverAge\ProcessBundle\Logger\TaskProcessor
+        public: false
         tags:
             - { name: monolog.processor, channel: cleverage_process_task }
+        arguments:
+            - '@process_bundle.manager.process'
 
-    CleverAge\ProcessBundle\Logger\TransformerProcessor:
-        autowire: true
+    cleverage_process.logger.transformer_processor:
+        class: CleverAge\ProcessBundle\Logger\TransformerProcessor
+        public: false
         tags:
             - { name: monolog.processor, channel: cleverage_process_transformer }
+        arguments:
+            - '@process_bundle.manager.process'
 
-    CleverAge\ProcessBundle\Logger\ProcessLogger:
-        autowire: true
+    cleverage_process.logger.process_logger:
+        class: CleverAge\ProcessBundle\Logger\ProcessLogger
+        public: false
         tags:
             - { name: monolog.logger, channel: cleverage_process }
+        arguments:
+            - '@monolog.logger'
 
-    CleverAge\ProcessBundle\Logger\TaskLogger:
-        autowire: true
+    cleverage_process.logger.task_logger:
+        class: CleverAge\ProcessBundle\Logger\TaskLogger
+        public: false
         tags:
             - { name: monolog.logger, channel: cleverage_process_task }
+        arguments:
+            - '@monolog.logger'

config/services/manager.yaml

@@ -1,9 +1,15 @@
 services:
-    CleverAge\ProcessBundle\Manager\ProcessManager:
-        autowire: true
+    process_bundle.manager.process:
+        class: CleverAge\ProcessBundle\Manager\ProcessManager
         public: false
         arguments:
-            $container: '@service_container'
+            - '@service_container'
+            - '@cleverage_process.logger.process_logger'
+            - '@cleverage_process.logger.task_logger'
+            - '@process_bundle.registry.process_configuration'
+            - '@process_bundle.context.contextual_option_resolver'
+            - '@event_dispatcher'
 
-    CleverAge\ProcessBundle\Context\ContextualOptionResolver:
+    process_bundle.context.contextual_option_resolver:
+        class: CleverAge\ProcessBundle\Context\ContextualOptionResolver
         public: false

config/services/registry.yaml

@@ -1,8 +1,11 @@
 services:
-    CleverAge\ProcessBundle\Registry\ProcessConfigurationRegistry:
+    process_bundle.registry.process_configuration:
+        class: CleverAge\ProcessBundle\Registry\ProcessConfigurationRegistry
+        public: false
         arguments:
             - ~
             - ~
 
-    CleverAge\ProcessBundle\Registry\TransformerRegistry:
+    process_bundle.registry.transformer:
+        class: CleverAge\ProcessBundle\Registry\TransformerRegistry
         public: false

config/services/task.yaml

@@ -1,6 +1,12 @@
 services:
+    _defaults:
+        bind:
+            $processManager: '@process_bundle.manager.process'
+            $processRegistry: '@process_bundle.registry.process_configuration'
+            $transformerRegistry: '@process_bundle.registry.transformer'
+
     CleverAge\ProcessBundle\Task\:
-        resource: '../../../Task/*'
+        resource: '../../src/Task/*'
         autowire: true
         public: true
         shared: false

config/services/transformer.yaml

@@ -1,14 +1,15 @@
 services:
     _defaults:
-        autowire: true
-        autoconfigure: true
-        public: true
         bind:
             $language: '@cleverage_process.expression_language'
+            $transformerRegistry: '@process_bundle.registry.transformer'
 
     CleverAge\ProcessBundle\Transformer\:
-        resource: '../../../Transformer/*'
-        exclude: '../../../Transformer/GenericTransformer.php'
+        resource: '../../src/Transformer/*'
+        exclude: '../../src/Transformer/GenericTransformer.php'
+        autowire: true
+        autoconfigure: true
+        public: true
         tags:
             - { name: cleverage.transformer }
             - { name: monolog.logger, channel: cleverage_process_transformer }

src/DependencyInjection/CleverAgeProcessExtension.php

@@ -37,7 +37,7 @@ public function load(array $configs, ContainerBuilder $container): void
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $processConfigurationRegistry = $container->getDefinition(ProcessConfigurationRegistry::class);
+        $processConfigurationRegistry = $container->getDefinition('process_bundle.registry.process_configuration');
         $processConfigurationRegistry->replaceArgument(0, $config['configurations']);
         $processConfigurationRegistry->replaceArgument(1, $config['default_error_strategy']);