Skip to content

ci(lint): add shell linter - Differential ShellCheck #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

ci(lint): add shell linter - Differential ShellCheck #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53732ba
ci(lint): add shell linter - Differential ShellCheck
jamacku Feb 21, 2024
7bd9df0
fix(SC2153): mitigate ShellCheck defect for `$DRAFT_RELEASE`
jamacku Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/differential-shellcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Differential ShellCheck
on:
push:
branches: [ trunk ]
pull_request:
branches: [ trunk ]

permissions:
contents: read

jobs:
lint:
runs-on: ubuntu-latest

permissions:
security-events: write

steps:
- name: Repository checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- id: ShellCheck
name: Differential ShellCheck
uses: redhat-plumbers-in-action/differential-shellcheck@v5
with:
token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion build_and_release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ if [[ $GH_RELEASE_TAG = *-* ]]; then
fi

draft_release=""
if [[ "$DRAFT_RELEASE" = "true" ]]; then
if [[ "${DRAFT_RELEASE:-}" = "true" ]]; then
draft_release="--draft"
fi

Expand Down