-
Notifications
You must be signed in to change notification settings - Fork 67
Add useful template functions to jq filters #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Relates to #10262 but needs to be used in cli/cli if accepted.
heaths
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xdevalias if acceptable to the CLI devs, this could be the basis for using some --template functions in --jq filters. Most of them don't make sense or have equivalents already in jq, though: https://jqlang.github.io/jq/manual/
If acceptable, I can document this in the CLI's README and help content. I think even what's there could use some sprucing up anyway e.g., to link acceptable formats to https://pkg.go.dev/time#Layout.
@heaths Sounds good to me! Appreciate your efforts! 🖤 |
Proper link to issue (since it's in a different repo): @andyfeller Curious if you (or someone more appropriate on your team perhaps) had some bandwidth to give a /2c on this PR in general; particularly around if/what concerns/blockers there would be to landing it (aside from the obvious fact that it needs a rebase; but if there are larger concerns with the feature/approach then that sort of 'polish'/'upkeep' would be irrelevant) I know there is this issue for some of the more tangentially related issues connected to this; but looking at the changes here, I don't think this PR would really fall under the scope of the concerns raised in it: |
fc806063
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relates to #10262 but needs to be used in cli/cli if accepted.