Skip to content

Commit 74578e1

Browse files
authored
Merge pull request #70 from click-contrib/tests-disable-check-help-for-missing-group-decorator
Disable asserts for missing group decorator when --help in tests
2 parents d92c06c + adfc215 commit 74578e1

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

.readthedocs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ formats:
1616

1717
# Optionally set the version of Python and requirements required to build your docs
1818
python:
19-
version: 3.7
19+
version: 3.11
2020
install:
2121
- method: pip
2222
path: .

tests/test_click_option_group.py

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -105,35 +105,39 @@ def test_missing_group_decl_first_api(runner):
105105
def cli(**params):
106106
pass
107107

108-
result = runner.invoke(cli, ["--help"])
109-
110-
assert result.exception
111-
assert isinstance(result.exception, TypeError)
112-
assert "Missing option group decorator" in str(result.exc_info[1])
113-
assert "--foo" in str(result.exc_info[1])
114-
assert "--bar" in str(result.exc_info[1])
108+
# FIXME: https://github.com/click-contrib/click-option-group/issues/65
109+
# Now we just do not check not attached options for --help
110+
# because handle_parse_result is not called in click >=8.1.8 for --help
111+
112+
# result = runner.invoke(cli, ["--help"])
113+
#
114+
# assert result.exception
115+
# assert isinstance(result.exception, TypeError)
116+
# assert "Missing option group decorator" in str(result.exc_info[1])
117+
# assert "--foo" in str(result.exc_info[1])
118+
# assert "--bar" in str(result.exc_info[1])
115119

116120
result = runner.invoke(cli, [])
117121

118122
assert result.exception
119123
assert isinstance(result.exception, TypeError)
120-
assert "Missing option group" in str(result.exc_info[1])
124+
assert "Missing option group decorator" in str(result.exc_info[1])
121125
assert "--foo" in str(result.exc_info[1])
122126
assert "--bar" in str(result.exc_info[1])
123127

124128
result = runner.invoke(cli, ["--hello1", "hello1"])
125129

126130
assert result.exception
127131
assert isinstance(result.exception, TypeError)
128-
assert "Missing option group" in str(result.exc_info[1])
132+
assert "Missing option group decorator" in str(result.exc_info[1])
129133
assert "--foo" in str(result.exc_info[1])
130134
assert "--bar" in str(result.exc_info[1])
131135

132136
result = runner.invoke(cli, ["--foo", "foo"])
133137

134138
assert result.exception
135139
assert isinstance(result.exception, TypeError)
136-
assert "Missing option group" in str(result.exc_info[1])
140+
assert "Missing option group decorator" in str(result.exc_info[1])
137141
assert "--foo" in str(result.exc_info[1])
138142
assert "--bar" in str(result.exc_info[1])
139143

0 commit comments

Comments
 (0)