Skip to content

Commit c3778e9

Browse files
authored
fix(types): fix Paper class method parameter typings in joint.d.ts (#3195)
1 parent 4ee9041 commit c3778e9

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

packages/joint-core/types/joint.d.ts

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1908,7 +1908,7 @@ export namespace dia {
19081908
layers: SVGGElement;
19091909

19101910
GUARDED_TAG_NAMES: string[];
1911-
FORM_CONTROLS_TAG_NAMES: string[];
1911+
FORM_CONTROL_TAG_NAMES: string[];
19121912

19131913
matrix(): SVGMatrix;
19141914
matrix(ctm: SVGMatrix | Vectorizer.Matrix, data?: any): this;
@@ -2094,9 +2094,9 @@ export namespace dia {
20942094

20952095
removeLayerView(layerRef: Paper.LayerRef): void;
20962096

2097-
protected insertLayerView(layerView: LayerView, before?: Paper.LayerRef): void;
2097+
protected insertLayerView(layerView: LayerView, beforeLayerView?: LayerView): void;
20982098

2099-
protected requestLayerViewRemoval(layerRef: Paper.LayerRef): void;
2099+
protected requestLayerViewRemoval(layerRef: Paper.LayerRef, opt?: { [key: string]: any }): void;
21002100

21012101
protected createLayerView(options: Omit<LayerView.Options, 'paper'>): LayerView;
21022102

@@ -2185,9 +2185,9 @@ export namespace dia {
21852185

21862186
protected updateViewsBatch(opt?: Paper.UpdateViewsBatchOptions): Paper.RenderBatchStats;
21872187

2188-
protected checkMountedViews(viewport: Paper.ViewportCallback, opt?: Paper.UnmountOptions): number;
2188+
protected checkMountedViews(viewport: Paper.ViewportCallback | Paper.CellVisibilityCallback | null, opt?: Paper.UnmountOptions): number;
21892189

2190-
protected checkUnmountedViews(viewport: Paper.ViewportCallback, opt?: Paper.MountOptions): number;
2190+
protected checkUnmountedViews(viewport: Paper.ViewportCallback | Paper.CellVisibilityCallback | null, opt?: Paper.MountOptions): number;
21912191

21922192
protected prioritizeCellViewMount(cellOrId: Graph.CellRef): boolean;
21932193

@@ -2201,9 +2201,9 @@ export namespace dia {
22012201

22022202
protected isExactSorting(): boolean;
22032203

2204-
protected sortViews(): void;
2204+
protected sortLayerViews(): void;
22052205

2206-
protected sortViewsExact(): void;
2206+
protected sortLayerViewsExact(): void;
22072207

22082208
protected pointerdblclick(evt: dia.Event): void;
22092209

@@ -2235,15 +2235,15 @@ export namespace dia {
22352235

22362236
protected guard(evt: dia.Event, view: CellView): boolean;
22372237

2238-
protected drawBackgroundImage(img: HTMLImageElement, opt: { [key: string]: any }): void;
2238+
protected drawBackgroundImage(img: HTMLImageElement | null, opt?: { [key: string]: any }): void;
22392239

2240-
protected updateBackgroundColor(color: string): void;
2240+
protected updateBackgroundColor(color?: string): void;
22412241

22422242
protected updateBackgroundImage(opt: { position?: any, size?: any }): void;
22432243

2244-
protected createViewForModel(cell: Cell): CellView;
2244+
protected createViewForModel(cell: Cell, cid?: string): CellView;
22452245

2246-
protected cloneOptions(): Paper.Options;
2246+
protected cloneOptions(): void;
22472247

22482248
protected onCellAdded(cell: Cell, collection: mvc.Collection<Cell>, opt: dia.Graph.Options): void;
22492249

@@ -2258,13 +2258,13 @@ export namespace dia {
22582258

22592259
protected onGraphLayerCollectionReset(layer: mvc.Collection<GraphLayer>, opt: dia.Graph.Options): void;
22602260

2261-
protected onGraphLayerCollectionSort(layer: GraphLayer[]): void;
2261+
protected onGraphLayerCollectionSort(layerCollection: mvc.Collection<GraphLayer>): void;
22622262

22632263
protected onGraphReset(cells: mvc.Collection<Cell>, opt: dia.Graph.Options): void;
22642264

22652265
protected onGraphSort(): void;
22662266

2267-
protected onGraphBatchStop(): void;
2267+
protected onGraphBatchStop(data?: { batchName: string }): void;
22682268

22692269
protected onCellHighlight(cellView: CellView, magnetEl: SVGElement, opt?: { highlighter?: highlighters.HighlighterJSON }): void;
22702270

@@ -2276,7 +2276,7 @@ export namespace dia {
22762276

22772277
protected removeViews(): void;
22782278

2279-
protected renderView(cell: Cell): CellView;
2279+
protected renderView(cell: Cell, opt?: { [key: string]: any }): CellView;
22802280

22812281
protected resetViews(cells?: Cell[], opt?: { [key: string]: any }): void;
22822282

0 commit comments

Comments
 (0)