Fixed test and release first version of library

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>

Author: vincenzopalazzo

.github/workflows/release.yml

@@ -2,9 +2,9 @@ name: Publish package to the Maven Central Repository
 on:
   release:
     types: [created]
-  push:
-    branches:
-      - main
+  #push:
+  #  branches:
+  #    - main
 jobs:
   build:
     runs-on: ubuntu-latest

gradle.properties

@@ -1,11 +1,4 @@
 GROUP_ID=io.github.clightning4j
 ARTIFACT_ID=lite-bitcoin-rpc
-VERSION=0.0.1-rc1-SNAPSHOT
-MODULE_NAME=io.clightning4j.litebitcoinrpc
-
-#Information abaut the maven repository
-signing.keyId=
-signing.password=
-signing.secretKeyRingFile=
-ossrhUsername=
-ossrhPassword=
+VERSION=0.0.1-rc1
+MODULE_NAME=io.clightning4j.litebitcoinrpc

lib/src/main/java/io/github/clightning4j/litebtc/LiteBitcoinRPC.java

@@ -63,8 +63,6 @@ public <T> T makeBitcoinRequest(Parameters parameters, Class<T> clazz)
       T result = HttpFactory.getInstance().makeRequest(parameters);
       String resultStr = converter.serialization(result);
       return (T) converter.deserialization(resultStr, clazz);
-    } catch (BitcoinCoreException bitcoinCoreException) {
-      throw bitcoinCoreException;
     } catch (UtilsExceptions utilsExceptions) {
       throw new LiteBitcoinRPCException(utilsExceptions.getCause());
     }

lib/src/main/java/io/github/clightning4j/litebtc/utils/okhttp/HttpFactory.java

@@ -84,6 +84,7 @@ public <T> T makeRequest(Parameters parameters) throws UtilsExceptions, BitcoinC
           ResponseWrapper<T> wrapper =
               (ResponseWrapper<T>) converter.deserialization(message, type);
           if (wrapper.getError() != null) {
+            LOGGER.debug("Bitcoin core error with message: " + wrapper.getError().getMessage());
             throw new BitcoinCoreException(
                 wrapper.getError().getCode(), wrapper.getError().getMessage());
           }
@@ -106,52 +107,4 @@ public <T> T makeRequest(Parameters parameters) throws UtilsExceptions, BitcoinC
       throw new UtilsExceptions(e.getCause());
     }
   }
-
-  public <T> T makeRequestTest(Parameters parameters) throws UtilsExceptions {
-    if (parameters == null) {
-      LOGGER.error("Parameters object null");
-      throw new UtilsExceptions("Parameters object null");
-    }
-    Authenticator.setDefault(
-        new Authenticator() {
-          @Override
-          protected PasswordAuthentication getPasswordAuthentication() {
-            return new PasswordAuthentication(
-                configuration.getUser(), configuration.getPass().toCharArray());
-          }
-        });
-
-    try {
-      HttpURLConnection httpcon =
-          (HttpURLConnection) new URL(configuration.getUrl()).openConnection();
-      httpcon.setDoOutput(true);
-      httpcon.setRequestProperty("Content-Type", "application/json");
-      httpcon.setRequestProperty("Accept", "application/json");
-      httpcon.setRequestMethod("POST");
-      httpcon.connect();
-
-      OutputStream stream = httpcon.getOutputStream();
-      String jsonBody = converter.serialization(parameters);
-      LOGGER.debug("JSON body:\n" + jsonBody);
-      stream.write(jsonBody.getBytes());
-      int code = httpcon.getResponseCode();
-      boolean isError = code >= 400 && code <= 500;
-      String text = "";
-      if (isError) {
-        LOGGER.error("Eroror with code: " + code);
-        throw new UtilsExceptions("error");
-      } else {
-        InputStream inputStream = httpcon.getInputStream();
-        if (inputStream != null) {
-          text = new String(inputStream.readAllBytes());
-        }
-      }
-      LOGGER.error("Response from bitcoind\n" + text);
-      Type type = new TypeToken<T>() {}.getType();
-      return (T) converter.deserialization(text, type.getClass());
-    } catch (IOException e) {
-      LOGGER.error("Exception in makeRequest" + e.getLocalizedMessage());
-      throw new UtilsExceptions(e.getCause());
-    }
-  }
 }

lib/src/main/resources/logback.xml

@@ -11,11 +11,21 @@
         </encoder>
     </appender>
 
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <!-- encoders are assigned the type
+             ch.qos.logback.classic.encoder.PatternLayoutEncoder by default -->
+        <encoder>
+            <pattern>%-4relative [%thread] %-5level %logger{35} - %msg %n</pattern>
+        </encoder>
+    </appender>
+
     <root level="INFO">
         <appender-ref ref="FILE" />
+        <appender-ref ref="STDOUT" />
     </root>
 
     <logger name="io.github.clightning4j.litebtc" level="INFO">
         <appender-ref ref="FILE" />
+        <appender-ref ref="STDOUT" />
     </logger>
 </configuration>

lib/src/test/java/io/github/clightning4j/litebtc/LiteBitcoinRPCTest.java

@@ -60,13 +60,19 @@ public void estimateFeeRateWithError() {
     }
   }
 
-  @Test(expected = BitcoinCoreException.class)
-  public void getUTXOWithError() throws BitcoinCoreException, LiteBitcoinRPCException {
+  @Test
+  public void getUTXOWithError() {
     Parameters parameters = new Parameters("gettxout");
     parameters.addParameter("txid", "txid");
     parameters.addParameter("n", 0);
-    bitcoinRPC.makeBitcoinRequest(parameters, BitcoinUTXO.class);
-    TestCase.fail("Expected BitcoinCoreException but we not receive it");
+    try {
+      bitcoinRPC.makeBitcoinRequest(parameters, BitcoinUTXO.class);
+      TestCase.fail("Expected BitcoinCoreException but we not receive it");
+    } catch (LiteBitcoinRPCException e) {
+      TestCase.fail("Wrong exception received (LiteBitcoinRPCException)");
+    } catch (BitcoinCoreException bitcoinCoreException) {
+      TestCase.assertNotNull(bitcoinCoreException);
+    }
   }
 
   @Test
@@ -76,11 +82,11 @@ public void getUTXOWithErrorWithMessage() throws LiteBitcoinRPCException {
     parameters.addParameter("n", 0);
     try {
       bitcoinRPC.makeBitcoinRequest(parameters, BitcoinUTXO.class);
+      TestCase.fail("Expected BitcoinCoreException but we not receive it");
     } catch (BitcoinCoreException bitcoinCoreException) {
       TestCase.assertEquals(-8, bitcoinCoreException.getCode());
       TestCase.assertEquals(
           "txid must be of length 64 (not 4, for 'txid')", bitcoinCoreException.getMessage());
     }
-    TestCase.fail("Expected BitcoinCoreException but we not receive it");
   }
 }

lib/src/test/resources/logback.xml

@@ -11,11 +11,21 @@
         </encoder>
     </appender>
 
+    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+        <!-- encoders are assigned the type
+             ch.qos.logback.classic.encoder.PatternLayoutEncoder by default -->
+        <encoder>
+            <pattern>%-4relative [%thread] %-5level %logger{35} - %msg %n</pattern>
+        </encoder>
+    </appender>
+
     <root level="INFO">
         <appender-ref ref="FILE" />
+        <appender-ref ref="STDOUT" />
     </root>
 
     <logger name="io.github.clightning4j.litebtc" level="DEBUG">
         <appender-ref ref="FILE" />
+        <appender-ref ref="STDOUT" />
     </logger>
 </configuration>