Skip to content

Commit 3756ab7

Browse files
authored
Merge pull request #934 from clinwiki-org/presearch-bugs
Presearch bugs
2 parents 8782de8 + 0d65469 commit 3756ab7

File tree

8 files changed

+518
-323
lines changed

8 files changed

+518
-323
lines changed

.vscode/settings.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,8 @@
33
"ruby.specCommand": "bundle exec rspec",
44
"prettier.configPath": "./front/.prettierrc",
55
"prettier.packageManager": "yarn",
6-
"editor.defaultFormatter": "esbenp.prettier-vscode"
6+
"editor.defaultFormatter": "esbenp.prettier-vscode",
7+
"[typescriptreact]": {
8+
"editor.defaultFormatter": "vscode.typescript-language-features"
9+
}
710
}

front/src/containers/AggDropDown/AggDropDown.tsx

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -28,27 +28,11 @@ import { FieldDisplay } from 'types/globalTypes';
2828
import './AggDropDownStyle.css';
2929
import { PresentSiteFragment, PresentSiteFragment_siteView } from 'types/PresentSiteFragment';
3030
import SortKind from './SortKind';
31-
import BucketsPanel from './BucketsPanel';
32-
import Filter from './Filter';
3331
import SearchPageCrowdAggBucketsQuery from 'queries/SearchPageCrowdAggBucketsQuery';
3432
import SearchPageAggBucketsQuery from 'queries/SearchPageAggBucketsQuery';
35-
import RangeSelector from './RangeSelector';
36-
import TwoLevelPieChart from './TwoLevelPieChart';
37-
import BarChartComponent from './BarChart'
38-
import AllowMissingCheckbox from './AllowMissingCheckbox';
3933
import { ApolloClient } from '@apollo/client';
4034
import { capitalize } from 'utils/helpers';
41-
import {
42-
ThemedPresearchCard,
43-
ThemedPresearchHeader,
44-
PresearchTitle,
45-
PresearchFilter,
46-
PresearchPanel,
47-
PresearchContent,
48-
} from 'components/StyledComponents';
4935
import {withPresentSite2} from "../PresentSiteProvider/PresentSiteProvider";
50-
import BucketsDropDown from './BucketsDropDown';
51-
import LocationAgg from './LocationAgg';
5236
import CustomDropDown from './CustomDrop';
5337
import AggFilterInputUpdater from 'containers/SearchPage/components/AggFilterInputUpdater';
5438
import { withAggContext } from 'containers/SearchPage/components/AggFilterUpdateContext';

front/src/containers/AggDropDown/AggKeyValuePairsDropDown.tsx

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -30,24 +30,9 @@ import './AggDropDownStyle.css';
3030
import { PresentSiteFragment, PresentSiteFragment_siteView } from 'types/PresentSiteFragment';
3131
import SortKind from './SortKind';
3232
import BucketsKeyValuePanel from './BucketsKeyValuePanel';
33-
import Filter from './Filter';
3433
import SearchPageCrowdAggBucketsQuery from 'queries/SearchPageCrowdAggBucketsQuery';
3534
import SearchPageAggBucketsQuery from 'queries/SearchPageAggBucketsQuery';
36-
import RangeSelector from './RangeSelector';
37-
import TwoLevelPieChart from './TwoLevelPieChart';
38-
import BarChartComponent from './BarChart'
39-
import AllowMissingCheckbox from './AllowMissingCheckbox';
40-
import { capitalize } from 'utils/helpers';
41-
import {
42-
ThemedPresearchCard,
43-
ThemedPresearchHeader,
44-
PresearchTitle,
45-
PresearchFilter,
46-
PresearchPanel,
47-
PresearchContent,
48-
} from 'components/StyledComponents';
4935
import {withPresentSite2} from "../PresentSiteProvider/PresentSiteProvider";
50-
import BucketsDropDown from './BucketsDropDown';
5136

5237
const PAGE_SIZE = 25;
5338

front/src/containers/AggDropDown/AllowMissingCheckbox.tsx renamed to front/src/containers/AggDropDown/AllowMissingDropDownItem.tsx

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,15 @@
11
import * as React from 'react';
22
import { withAggContext } from 'containers/SearchPage/components/AggFilterUpdateContext';
33
import AggFilterInputUpdater from 'containers/SearchPage/components/AggFilterInputUpdater';
4-
import { Checkbox } from 'react-bootstrap';
54
import { AggBucket } from '../SearchPage/Types';
65
import bucketKeyIsMissing from 'utils/aggs/bucketKeyIsMissing';
76

8-
interface AllowMissingCheckboxProps {
7+
interface AllowMissingDropDownItemProps {
98
buckets: AggBucket[] | null;
109
updater: AggFilterInputUpdater;
1110
}
1211

13-
function AllowMissingCheckbox(props: AllowMissingCheckboxProps) {
12+
function AllowMissingDropDownItem(props: AllowMissingDropDownItemProps) {
1413
const { buckets, updater } = props;
1514
let totalMissing: number = 0;
1615
(buckets || []).forEach(bucket => {
@@ -19,12 +18,10 @@ function AllowMissingCheckbox(props: AllowMissingCheckboxProps) {
1918
}
2019
});
2120
return (
22-
<Checkbox
23-
checked={updater.allowsMissing()}
24-
onChange={() =>
25-
updater.toggleAllowMissing()
26-
}>{`Allow Missing (${totalMissing})`}</Checkbox>
21+
<div
22+
className="item-content"
23+
>{`Allow Missing (${totalMissing})`}</div>
2724
);
2825
}
2926

30-
export default withAggContext(AllowMissingCheckbox);
27+
export default withAggContext(AllowMissingDropDownItem);

0 commit comments

Comments
 (0)