Fail when giving both use-h2c? true *and* and ssl-context

Author: DerGuteMoritz

src/aleph/http/server.clj

@@ -764,6 +764,10 @@
                (some #{:http2} http-versions))
       (throw (IllegalArgumentException. "HTTP/2 requires ssl-context to be given or use-h2c? to be true.")))
 
+    (when (and ssl-context
+               use-h2c?)
+      (throw (IllegalArgumentException. "use-h2c? must not be true when ssl-context is given.")))
+
     (netty/start-server
       {:pipeline-builder    pipeline-builder
        :bootstrap-transform bootstrap-transform

test/aleph/http_test.clj

@@ -1410,9 +1410,10 @@
                   {:use-h2c? true
                    :http-versions [:http2]})]
       (is (= :started result))))
-  (testing "HTTP/2 with ssl-context *and* with h2c (which has no effect then)"
+  (testing "HTTP/2 with ssl-context *and* with h2c"
     (let [result (try-start-server
                   {:use-h2c? true
                    :http-versions [:http2]
                    :ssl-context test-ssl/server-ssl-context-opts})]
-      (is (= :started result)))))
+      (is (instance? IllegalArgumentException result))
+      (is (= "use-h2c? must not be true when ssl-context is given." (ex-message result))))))