Rename go-off-executor to go-off-with

Better matches existing future-with macro

Author: KingMob

src/manifold/go_off.clj

@@ -71,7 +71,7 @@
   {'manifold.go-off/<! `manifold.go-off/take!
    :Return             `return-deferred})
 
-(defmacro go-off-executor
+(defmacro go-off-with
   "Implementation of go-off that allows specifying executor. See docstring of go-off for usage."
   [executor & body]
   (let [executor     (vary-meta executor assoc :tag 'java.util.concurrent.Executor)
@@ -118,7 +118,7 @@
    - `deferred/chain` only works with single deferreds, which means having to write code in
    unnatural ways to handle multiple deferreds."
   [& body]
-  `(go-off-executor (ex/execute-pool) ~@body))
+  `(go-off-with (ex/execute-pool) ~@body))
 
 
 (comment

test/manifold/go_off_test.clj

@@ -1,6 +1,6 @@
 (ns manifold.go-off-test
   (:require [clojure.test :refer :all]
-            [manifold.go-off :refer [go-off <!? go-off-executor]]
+            [manifold.go-off :refer [go-off <!? go-off-with]]
             [manifold.deferred :as d]
             [manifold.test-utils :refer :all]
             [manifold.executor :as ex]
@@ -132,9 +132,9 @@
                                                                     #(str prefix (swap! cnt inc))
                                                                     (deliver (promise) nil))
                                                   :stats-callback (constantly nil)})]
-    (try (is (str/starts-with? @(go-off-executor custom-executor (.getName (Thread/currentThread))) prefix)
+    (try (is (str/starts-with? @(go-off-with custom-executor (.getName (Thread/currentThread))) prefix)
              "Running on custom executor, thread naming should be respected.")
-         @(go-off-executor custom-executor (.getName (Thread/currentThread)))
+         @(go-off-with custom-executor (.getName (Thread/currentThread)))
          (finally (.shutdown custom-executor)))))
 
 (deftest go-off-streams