Skip to content

Commit 91ad622

Browse files
committed
fixup! Fix typo
1 parent 7481f56 commit 91ad622

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/manifold/executor.clj

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,14 @@
3333
(.set executor-thread-local executor#)))))
3434

3535
(defn- ^Thread new-thread
36-
"Create a new `java.lang.Thread`.
36+
"Creates a new `java.lang.Thread`.
3737
3838
It represents the default implementation on `thread-factory` when the
39-
`new-thread-fn` argument is not passed."
39+
`new-thread-fn` argument is not passed.
40+
41+
Some libraries require a different implementation of a `java.lang.Thread`.
42+
That's the case of Netty which behaves differently when
43+
running on a `io.netty.util.concurrent.FastThreadLocalThread`."
4044
[group target name stack-size]
4145
(Thread. group target name stack-size))
4246

test/manifold/executor_test.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656

5757
(deftest test-thread-factory
5858
(let [tf (thread-factory)]
59-
(.newThread tf (constantly nil)))
59+
(is (.newThread tf (constantly nil))))
6060
(let [tf (thread-factory
6161
(fn [group target _ stack-size]
6262
(proxy [Thread] [group target "custom-name" stack-size])))

0 commit comments

Comments
 (0)