Coerced string now escape inner double quotes

When coercing a Clojure string to a rewrite-clj node, double quotes
within the string are now escaped.

This was the behavior for rewrite-clj v0, and a regression in
rewrite-clj v1.

Fixes #176

Author: lread

CHANGELOG.adoc

@@ -16,8 +16,10 @@ For a list of breaking changes see link:#v1-breaking[breaking changes].
 
 === Unreleased
 
+* now properly escaping inline double quotes for coerced strings https://github.com/clj-commons/rewrite-clj/issues/176[#176] - thanks to @ivarref for raising the issue!
 * docs:
-** docstring fix, was missing list-node from toc, thanks @rfhayashi!
+** docstring fix, was missing `list-node` from toc, thanks @rfhayashi!
+
 
 === v1.0.767-alpha
 

src/rewrite_clj/node/coercer.cljc

@@ -92,10 +92,11 @@
 
 (defn- split-to-lines
   "Slightly different than string/split-lines in that:
+   - escape inline double quotes (to emulate the clojure reader)
    - includes all lines even if empty
    - behaves the same on clj and cljs"
   [s]
-  (loop [s s
+  (loop [s (string/escape s {\" "\\\""})
          lines []]
     (if-let [m (first (re-find #"(\r\n|\r|\n)" s))]
       (let [eol-ndx (string/index-of s m)]

test/rewrite_clj/node/coercer_test.cljc

@@ -48,6 +48,7 @@
       "\n"                   :multi-line :string
       "\n\n"                 :multi-line :string
       ","                    :token      :string
+      "inner\"quote"         :token      :string
 
       ;; seqs
       []                     :vector     :seq