Skip to content

Commit 0d6e484

Browse files
committed
Udate codecov script sha verification on CI
Since the security breach at codecov, we've been verifying the codecov script before running it. The codecov sha sum files include an entry for "codecov" which we use, and another for "env" which we do not. A recent GitHub Actions image update also seems to have updated sha sum utilities. We are now required to provide --ignore-missing for downloaded codecov sha sum files so that "env" can be ignored and not cause a failure. This seems like a sensible and conservative default. So... good! I verified that if the "codecov" file is missing (in other words everything is missing), we'll still fail, which is what want.
1 parent db4ed08 commit 0d6e484

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/code-coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
VERSION=$(grep 'VERSION=\".*\"' codecov | cut -d'"' -f2);
5454
for i in 1 256 512
5555
do
56-
sha${i}sum -c <(curl -s "https://raw.githubusercontent.com/codecov/codecov-bash/${VERSION}/SHA${i}SUM")
56+
sha${i}sum -c --ignore-missing <(curl -s "https://raw.githubusercontent.com/codecov/codecov-bash/${VERSION}/SHA${i}SUM")
5757
done
5858
echo "Uploading to codecov"
5959
bash codecov -f target/coverage/codecov.json

0 commit comments

Comments
 (0)