Setup and satisfy Eastwood

Author: vemv

.github/workflows/unit-test.yml

@@ -147,3 +147,8 @@ jobs:
     #
     - name: Run CI tests
       run: bb ci-unit-tests
+
+    # Runs after ci-unit-tests (which runs clj-kondo), for fail-fast behavior (as Eastwood is slower)
+    - name: Lint with Eastwood
+      run: clojure -A:test-common:eastwood
+       

deps.edn

@@ -24,7 +24,9 @@
            :clj-kondo {:extra-deps {clj-kondo/clj-kondo {:mvn/version "2021.04.23"}}
                        :main-opts ["-m" "clj-kondo.main"]}
 
-
+           :eastwood {:extra-deps {jonase/eastwood {:mvn/version "0.6.0"}}
+                      :main-opts ["-m" "eastwood.lint" {:ignored-faults {:deprecations {rewrite-clj.regression-test true
+                                                                                        rewrite-clj.zip.whitespace-test true}}}]}
 
            :test-common {:extra-deps {org.clojure/test.check {:mvn/version "1.1.0"}}
                          :extra-paths ["test"]}

test/rewrite_clj/examples/cljx_test.cljc

@@ -64,7 +64,7 @@
 (defn- handle-reader-macro
   "Handle a reader macro node by either removing it completely or only the macro part."
   [active-profiles zloc]
-  {:pre (= (z/tag zloc) :reader-macro)}
+  {:pre [(= (z/tag zloc) :reader-macro)]}
   (let [profile (-> zloc z/down z/sexpr name)
         active? (contains? active-profiles (subs profile 1))
         print? (.startsWith profile "+")]

test/rewrite_clj/paredit_test.cljc

@@ -231,8 +231,8 @@ First line
                 z/of-string
                 z/down z/right z/down ;at 2
                 pe/slurp-forward)]
-    (is (= "[1 [2 [3 4] 5]]" (-> res z/root-string))
-        (= "2" (-> res z/string)))))
+    (is (= "[1 [2 [3 4] 5]]" (-> res z/root-string)))
+    (is (= "2" (-> res z/string)))))
 
 (deftest slurp-forward-keep-linebreak
   (let [sample "
@@ -405,22 +405,22 @@ First line
              (pe/wrap-fully-forward-slurp :vector)
              z/root-string))))
 
-(deftest splice-killing-backward []
+(deftest splice-killing-backward
   (let [res (-> (z/of-string "(foo (let ((x 5)) (sqrt n)) bar)")
              z/down z/right z/down z/right z/right
              pe/splice-killing-backward)]
     (is (= "(foo (sqrt n) bar)" (z/root-string res)))
     (is (= "(sqrt n)" (z/string res)))))
 
 
-(deftest splice-killing-forward []
+(deftest splice-killing-forward
   (let [res (-> (z/of-string "(a (b c d e) f)")
              z/down z/right z/down z/right z/right
              pe/splice-killing-forward)]
     (is (= "(a b c f)" (z/root-string res)))
     (is (= "c" (z/string res)))))
 
-(deftest splice-killing-forward-at-leftmost []
+(deftest splice-killing-forward-at-leftmost
   (let [res (-> (z/of-string "(a (b c d e) f)")
              z/down z/right z/down
              pe/splice-killing-forward)]