dev: Update babashka scripts to avoid side effects

This might be considered a bit overly meticulous at this point but it
could save confusion at some later date.

Scripts were previously always invoking the main function.
Thing is, this is not always technically appropriate.
For example, if someone issues a `bb doc` on a rewrite-clj script var,
main will be invoked.

With a pointer from borkdude to check out
https://book.babashka.org/#main_file, we now only automatically invoke
main when the clj file was invoked as a script.

I also adjusted all scripts to have a proper `-main` so that
for example:
./script/apply_import_vars.clj check
can alternatively be invoked via:
bb -m apply-import-vars check

I'll stick with the ./script invocation in our docs, as most shells
offer autocompletion for files.

Author: lread

script/apply_import_vars.clj

@@ -5,7 +5,7 @@
             [helper.shell :as shell]
             [helper.status :as status]))
 
-(defn main[args]
+(defn -main[& args]
   (env/assert-min-versions)
   (let [cmd (first args)]
     (when (not (#{"gen-code" "check"} cmd))
@@ -14,4 +14,5 @@
     (shell/command ["clojure" "-X:apply-import-vars:script" cmd])
     nil))
 
-(main *command-line-args*)
+(env/when-invoked-as-script
+ (apply -main *command-line-args*))

script/ci_tests.clj

@@ -10,7 +10,7 @@
   (doseq [dir ["target" ".cpcache .shadow-cljs"]]
     (fs/delete-file-recursively dir true)))
 
-(defn lint[]
+(defn lint []
   (shell/command ["bb" "./script/lint.clj"]))
 
 (defn check-import-vars []
@@ -36,7 +36,7 @@
     (shell/command ["bb" "./script/cljs_tests.clj" "--env" "planck" "--optimizations" "none"])
     (status/line :warn "skipping planck tests, they can only be run on linux and macOS")) )
 
-(defn main[]
+(defn -main[]
   (env/assert-min-versions)
   (clean)
   (check-import-vars)
@@ -48,4 +48,5 @@
   (cljs-bootstrap-tests)
   nil)
 
-(main)
+(env/when-invoked-as-script
+ (-main))

script/clj_tests.clj

@@ -55,7 +55,7 @@
                   "--profile" "test-isolated"
                   "--reporter" "documentation"]))
 
-(defn main [args]
+(defn -main [& args]
   (env/assert-min-versions)
   (let [{:keys [options exit-message exit-code]} (validate-args args)]
     (if exit-message
@@ -64,4 +64,5 @@
           (run-isolated-tests options))))
   nil)
 
-(main *command-line-args*)
+(env/when-invoked-as-script
+ (apply -main *command-line-args*))

script/clj_watch.clj

@@ -5,6 +5,10 @@
             [helper.shell :as shell]
             [helper.status :as status]))
 
-(env/assert-min-versions)
-(status/line :info "launching kaocha watch on clojure sources")
-(shell/command (concat ["clojure" "-M:test-common:kaocha" "--watch" ] *command-line-args*))
+(defn -main []
+  (env/assert-min-versions)
+  (status/line :info "launching kaocha watch on clojure sources")
+  (shell/command (concat ["clojure" "-M:test-common:kaocha" "--watch"] *command-line-args*)))
+
+(env/when-invoked-as-script
+ (-main))

script/cljdoc_preview.clj

@@ -1,12 +1,13 @@
 #!/usr/bin/env bb
 
-(ns cljdoc-docker-preview
+(ns cljdoc-preview
   (:require [babashka.curl :as curl]
             [clojure.data.xml :as xml]
             [clojure.data.zip.xml :as zxml]
             [clojure.java.browse :as browse]
             [clojure.string :as string]
             [clojure.zip :as zip]
+            [helper.env :as env]
             [helper.fs :as fs]
             [helper.shell :as shell]
             [helper.status :as status]))
@@ -211,7 +212,7 @@
 (defn cleanup-resources []
   (fs/delete-file-recursively cljdoc-db-dir true))
 
-(defn main [args]
+(defn -main [& args]
 
   (check-prerequisites)
 
@@ -256,4 +257,5 @@
           (println "Must be run from project root directory.")
           (System/exit 1)))))
 
-(main *command-line-args*)
+(env/when-invoked-as-script
+ (apply -main *command-line-args*))

script/cljs_tests.clj

@@ -115,13 +115,13 @@
                                 (shell/command (concat cmd ["--namespace" ns])))
                               nses)))))))
 
-(defn main [args]
+(defn -main [& args]
   (env/assert-min-versions)
   (let [{:keys [options exit-message exit-code]} (validate-args args)]
     (if exit-message
       (exit exit-code exit-message)
       (run-tests options)))
   nil)
 
-(main *command-line-args*)
-
+(env/when-invoked-as-script
+ (apply -main *command-line-args*))

script/cljs_watch.clj

@@ -5,6 +5,10 @@
             [helper.shell :as shell]
             [helper.status :as status]))
 
-(env/assert-min-versions)
-(status/line :detail "compiling code, then opening repl, afterwich your web browser will automatically open to figwheel test run summary")
-(shell/command ["clojure" "-M:test-common:cljs:fig-test"])
+(defn -main []
+  (env/assert-min-versions)
+  (status/line :detail "compiling code, then opening repl, afterwich your web browser will automatically open to figwheel test run summary")
+  (shell/command ["clojure" "-M:test-common:cljs:fig-test"]))
+
+(env/when-invoked-as-script
+ (-main))

script/coverage.clj

@@ -17,10 +17,11 @@
                   "--no-randomize"
                   "--reporter" "documentation"]))
 
-(defn main []
+(defn -main []
   (env/assert-min-versions)
   (generate-doc-tests)
   (run-clj-doc-tests)
   nil)
 
-(main)
+(env/when-invoked-as-script
+ (-main))

script/doc_tests.clj

@@ -1,6 +1,6 @@
 #!/usr/bin/env bb
 
-(ns doc_tests
+(ns doc-tests
   (:require [helper.env :as env]
             [helper.shell :as shell]
             [helper.status :as status]))
@@ -23,11 +23,12 @@
                   "--dir" "target/test-doc-blocks/test"
                   "--out" "target/cljsbuild/doc-tests"]))
 
-(defn main []
+(defn -main []
   (env/assert-min-versions)
   (generate-doc-tests)
   (run-clj-doc-tests)
   (run-cljs-doc-tests)
   nil)
 
-(main)
+(env/when-invoked-as-script
+ (-main))

script/gen_api_diffs.clj

@@ -47,7 +47,7 @@
                           "--report-filename" (str  (io/file report-dir (str report-name ".adoc")))]
                          extra-args)))
 
-(defn main []
+(defn -main []
   (env/assert-min-versions)
   (let [opts {:notes-dir "doc/diff-notes"
               :report-dir "doc/generated/api-diffs"}
@@ -70,4 +70,5 @@
     (diff-apis opts rewrite-clj-v1-lang-cljs   rewrite-clj-v1-lang-clj   "rewrite-clj-v1-lang-cljs-and-rewrite-clj-v1-lang-clj-documented-only" (concat to-self-args documented-only-args)))
   nil)
 
-(main)
+(env/when-invoked-as-script
+ (-main))