From 683e9bda884900e6b4b8fd07bfd4c09d52e8d99d Mon Sep 17 00:00:00 2001 From: lread Date: Thu, 19 Sep 2024 15:01:41 -0400 Subject: [PATCH 1/2] test: temporarily disable refactor-nrepl lib tests See https://github.com/clojure-emacs/refactor-nrepl/issues/409 --- README.adoc | 2 +- script/test_libs.clj | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/README.adoc b/README.adoc index d608e0ce..4c7b604c 100644 --- a/README.adoc +++ b/README.adoc @@ -62,7 +62,7 @@ Some projects using rewrite-clj v1 // repo is not version tagged: * https://github.com/kit-clj/kit[kit] {not-canary-tested} - Lightweight, modular framework for scalable web development in Clojure * https://github.com/FiV0/kusonga[kusonga] {canary-tested} - Renaming and moving namespaces in Clojure(script) -* https://github.com/clojure-emacs/refactor-nrepl[refactor-nrepl] {canary-tested} - nREPL middleware to support refactorings in an editor agnostic way +* https://github.com/clojure-emacs/refactor-nrepl[refactor-nrepl] {not-canary-tested} - nREPL middleware to support refactorings in an editor agnostic way * https://github.com/pink-gorilla/reval[reval] {canary-tested} -reproduceable eval - namespace eval and storage with browser ui * https://github.com/borkdude/rewrite-edn[rewrite-edn] {canary-tested} - Utility lib on top of rewrite-clj with common operations to update EDN while preserving whitespace and comments * https://github.com/matthewdowney/rich-comment-tests[rich-comment-tests] {canary-tested} - Turns rich comment forms into tests diff --git a/script/test_libs.clj b/script/test_libs.clj index 50973355..46134abc 100755 --- a/script/test_libs.clj +++ b/script/test_libs.clj @@ -419,7 +419,8 @@ :patch-fn deps-edn-v1-patch :show-deps-fn cli-deps-tree :test-cmds ["clojure -M:test"]} - {:name "refactor-nrepl" + ;; temporarily disable, see https://github.com/clojure-emacs/refactor-nrepl/issues/409 + #_{:name "refactor-nrepl" :version "3.10.0" :platforms [:clj] :github-release {:repo "clojure-emacs/refactor-nrepl" From 3d3084405c17b257b4073e4cb030d927dfc412fb Mon Sep 17 00:00:00 2001 From: lread Date: Thu, 19 Sep 2024 15:12:55 -0400 Subject: [PATCH 2/2] lint --- script/test_libs.clj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/script/test_libs.clj b/script/test_libs.clj index 46134abc..eed44c55 100755 --- a/script/test_libs.clj +++ b/script/test_libs.clj @@ -214,8 +214,8 @@ ;; ;; refactor-nrepl ;; - -(defn- refactor-nrepl-patch +;; uncomment we we re-enable +#_(defn- refactor-nrepl-patch "custom because my generic does not handle ^:inline-dep syntax" [{:keys [home-dir rewrite-clj-version]}] (status/line :detail "=> Patching deps")