Remove some dead code (#3189)

# Description of Changes

This obscured other used code, so let's remove it as its dead.

# API and ABI breaking changes

None

# Expected complexity level and risk

-1

# Testing

Not applicable.

Author: Centril

crates/lib/src/lib.rs

@@ -2,7 +2,7 @@ use crate::db::raw_def::v9::RawModuleDefV9Builder;
 use crate::db::raw_def::RawTableDefV8;
 use anyhow::Context;
 use sats::typespace::TypespaceBuilder;
-use spacetimedb_sats::{impl_serialize, WithTypespace};
+use spacetimedb_sats::WithTypespace;
 use std::any::TypeId;
 use std::collections::{btree_map, BTreeMap};
 
@@ -126,68 +126,6 @@ pub struct ReducerDef {
     pub args: Vec<ProductTypeElement>,
 }
 
-impl ReducerDef {
-    pub fn encode(&self, writer: &mut impl buffer::BufWriter) {
-        bsatn::to_writer(writer, self).unwrap()
-    }
-
-    pub fn serialize_args<'a>(ty: sats::WithTypespace<'a, Self>, value: &'a ProductValue) -> impl ser::Serialize + 'a {
-        ReducerArgsWithSchema { value, ty }
-    }
-
-    pub fn deserialize(
-        ty: sats::WithTypespace<'_, Self>,
-    ) -> impl for<'de> de::DeserializeSeed<'de, Output = ProductValue> + '_ {
-        ReducerDeserialize(ty)
-    }
-}
-
-struct ReducerDeserialize<'a>(sats::WithTypespace<'a, ReducerDef>);
-
-impl<'de> de::DeserializeSeed<'de> for ReducerDeserialize<'_> {
-    type Output = ProductValue;
-
-    fn deserialize<D: de::Deserializer<'de>>(self, deserializer: D) -> Result<Self::Output, D::Error> {
-        deserializer.deserialize_product(self)
-    }
-}
-
-impl<'de> de::ProductVisitor<'de> for ReducerDeserialize<'_> {
-    type Output = ProductValue;
-
-    fn product_name(&self) -> Option<&str> {
-        Some(&self.0.ty().name)
-    }
-    fn product_len(&self) -> usize {
-        self.0.ty().args.len()
-    }
-    fn product_kind(&self) -> de::ProductKind {
-        de::ProductKind::ReducerArgs
-    }
-
-    fn visit_seq_product<A: de::SeqProductAccess<'de>>(self, tup: A) -> Result<Self::Output, A::Error> {
-        de::visit_seq_product(self.0.map(|r| &*r.args), &self, tup)
-    }
-
-    fn visit_named_product<A: de::NamedProductAccess<'de>>(self, tup: A) -> Result<Self::Output, A::Error> {
-        de::visit_named_product(self.0.map(|r| &*r.args), &self, tup)
-    }
-}
-
-struct ReducerArgsWithSchema<'a> {
-    value: &'a ProductValue,
-    ty: sats::WithTypespace<'a, ReducerDef>,
-}
-impl_serialize!([] ReducerArgsWithSchema<'_>, (self, ser) => {
-    use itertools::Itertools;
-    use ser::SerializeSeqProduct;
-    let mut seq = ser.serialize_seq_product(self.value.elements.len())?;
-    for (value, elem) in self.value.elements.iter().zip_eq(&self.ty.ty().args) {
-        seq.serialize_element(&self.ty.with(&elem.algebraic_type).with_value(value))?;
-    }
-    seq.end()
-});
-
 //WARNING: Change this structure (or any of their members) is an ABI change.
 #[derive(Debug, Clone, Default, SpacetimeType)]
 #[cfg_attr(feature = "test", derive(PartialEq, Eq, PartialOrd, Ord))]

crates/schema/src/def/deserialize.rs

@@ -1,8 +1,7 @@
 //! Helpers to allow deserializing data using a ReducerDef.
 
 use crate::def::ReducerDef;
-use spacetimedb_lib::sats::{self, de, ser, ProductValue};
-use spacetimedb_sats::impl_serialize;
+use spacetimedb_lib::sats::{self, de, ProductValue};
 
 /// Wrapper around a `ReducerDef` that allows deserializing to a `ProductValue` at the type
 /// of the reducer's parameter `ProductType`.
@@ -45,17 +44,3 @@ impl<'de> de::ProductVisitor<'de> for ReducerArgsDeserializeSeed<'_> {
         de::visit_named_product(self.0.map(|r| &*r.params.elements), &self, tup)
     }
 }
-
-pub struct ReducerArgsWithSchema<'a> {
-    value: &'a ProductValue,
-    ty: sats::WithTypespace<'a, ReducerDef>,
-}
-impl_serialize!([] ReducerArgsWithSchema<'_>, (self, ser) => {
-    use itertools::Itertools;
-    use ser::SerializeSeqProduct;
-    let mut seq = ser.serialize_seq_product(self.value.elements.len())?;
-    for (value, elem) in self.value.elements.iter().zip_eq(&*self.ty.ty().params.elements) {
-        seq.serialize_element(&self.ty.with(&elem.algebraic_type).with_value(value))?;
-    }
-    seq.end()
-});