[stacktrace] Remove analyze-stacktrace op

Author: alexander-yakushev

src/cider/nrepl/middleware/log.clj

@@ -4,14 +4,11 @@
    :added "0.32.0"}
   (:require [cider.nrepl.middleware.inspect :as middleware.inspect]
             [cider.nrepl.middleware.util.error-handling :refer [with-safe-transport]]
-            [haystack.analyzer :as analyzer]
-            [haystack.parser.clojure.throwable :as throwable]
             [logjam.event :as event]
             [logjam.framework :as framework]
             [nrepl.middleware.print :as print]
             [nrepl.misc :refer [response-for]]
-            [nrepl.transport :as transport]
-            [orchard.inspect :as orchard.inspect])
+            [nrepl.transport :as transport])
   (:import (java.io StringWriter)
            (java.util UUID)))
 
@@ -38,7 +35,7 @@
 (defn- select-exception
   "Return the `exception` in a Bencode compatible format."
   [exception]
-  (let [exception-map (throwable/Throwable->map exception)
+  (let [exception-map (Throwable->map exception)
         strip-cause #(dissoc % :data :trace)]
     (cond-> (strip-cause exception-map)
       (seq (:via exception-map))
@@ -167,16 +164,6 @@
          (deref)
          (select-appender))}))
 
-(defn analyze-stacktrace-reply
-  "Show the stacktrace of a log event in the debugger."
-  [{:keys [transport ::print/print-fn] :as msg}]
-  (let [event (event msg)]
-    (if-let [exception (:exception event)]
-      (do (doseq [cause (analyzer/analyze exception print-fn)]
-            (transport/send transport (response-for msg cause)))
-          (transport/send transport (response-for msg :status :done)))
-      (transport/send transport (response-for msg :status :no-error)))))
-
 (defn exceptions-reply
   "Return the exceptions and their frequencies for the given framework and appender."
   [msg]
@@ -272,7 +259,6 @@
   (with-safe-transport handler msg
     "cider/log-add-appender" add-appender-reply
     "cider/log-add-consumer" add-consumer-reply
-    "cider/log-analyze-stacktrace" analyze-stacktrace-reply
     "cider/log-clear-appender" clear-appender-reply
     "cider/log-exceptions" exceptions-reply
     "cider/log-format-event" format-event-reply

src/cider/nrepl/middleware/stacktrace.clj

@@ -5,7 +5,6 @@
    [cider.nrepl.middleware.util.nrepl :refer [notify-client]]
    [clojure.string :as str]
    [haystack.analyzer :as analyzer]
-   [haystack.parser :as parser]
    [nrepl.middleware.print :as print]
    [cider.nrepl.middleware.inspect :as middleware.inspect]
    [nrepl.misc :refer [response-for]]
@@ -46,23 +45,6 @@
     (no-error msg))
   (done msg))
 
-;; Analyze stacktrace
-
-(defn- analyze-stacktrace
-  "Parse and analyze the `stacktrace`."
-  [{:keys [stacktrace] :as msg}]
-  (if-let [analysis (some-> stacktrace parser/parse analyzer/analyze)]
-    (send-analysis msg analysis)
-    (no-error msg)))
-
-(defn- handle-analyze-stacktrace-op
-  "Handle the analyze stacktrace op."
-  [{:keys [stacktrace] :as msg}]
-  (if (not (str/blank? stacktrace))
-    (analyze-stacktrace msg)
-    (no-error msg))
-  (done msg))
-
 ;; Stacktrace
 
 (defn- handle-stacktrace-op
@@ -93,5 +75,4 @@
   (case op
     "analyze-last-stacktrace" (handle-analyze-last-stacktrace-op msg)
     "inspect-last-exception"  (handle-inspect-last-exception-op msg)
-    "analyze-stacktrace"      (handle-analyze-stacktrace-op msg)
     "stacktrace"              (handle-stacktrace-op msg)))

test/clj/cider/nrepl/middleware/log_test.clj

@@ -111,26 +111,6 @@
       ;; TODO: How to receive the async log event?
       )))
 
-(deftest test-analyze-stacktrace
-  (with-each-framework [framework (frameworks)]
-    (with-appender [framework appender]
-      (framework/log framework {:message "a-1" :exception (ex-info "BOOM" {:some (Object.)})})
-      (let [events (search-events framework appender {})]
-        (is (= 1 (count events)))
-        (let [event (first events)]
-          (is (uuid-str? (:id event)))
-          (is (string? (:level event)))
-          (is (string? (:logger event)))
-          (is (= "a-1" (:message event)))
-          (is (int? (:timestamp event)))
-          (let [response (session/message {:op "cider/log-analyze-stacktrace"
-                                           :framework (:id framework)
-                                           :appender (:id appender)
-                                           :event (:id event)})]
-            (is (= #{"done"} (:status response)))
-            (is (every? #(set/subset? #{:type :flags} (set (keys %)))
-                        (:stacktrace response)))))))))
-
 (deftest test-clear
   (with-each-framework [framework (frameworks)]
     (with-appender [framework appender]

test/clj/cider/nrepl/middleware/stacktrace_test.clj

@@ -63,21 +63,3 @@
     (let [response (session/message {:op "analyze-last-stacktrace"})]
       (testing "returns done and no-error status"
         (is (= #{"done" "no-error"} (:status response)))))))
-
-;; Analyze stacktrace op
-
-(deftest analyze-stacktrace-test
-  (testing "stacktrace op with stacktrace parameter"
-    (let [response (session/message {:op "analyze-stacktrace" "stacktrace" (pr-str (ex-info "BOOM" {:boom :data}))})]
-      (testing "returns the exception class"
-        (is (= "clojure.lang.ExceptionInfo" (:class response))))
-      (testing "returns the exception message"
-        (is (= "BOOM" (:message response))))
-      (testing "returns done status"
-        (is (= #{"done"} (:status response)))))))
-
-(deftest analyze-stacktrace-invalid-test
-  (testing "stacktrace op with invalid stacktrace parameter"
-    (let [response (session/message {:op "analyze-stacktrace" "stacktrace" "invalid"})]
-      (testing "returns done and no-error status"
-        (is (= #{"done" "no-error"} (:status response)))))))