Skip to content

Commit 3ea8b29

Browse files
committed
Fix a regression with see-also
The way the code was written it was acting on the ns/symbol that was passed to info, instead of the ns/symbol that were resolved.
1 parent 531d980 commit 3ea8b29

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/cider/nrepl/middleware/info.clj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,8 @@
8787
(and class member) (clj-info/info-java class member)
8888
:else (throw (Exception.
8989
"Either \"symbol\", or (\"class\", \"member\") must be supplied")))
90-
see-also (clj-info/see-also ns symbol)]
90+
;; we have to use the resolved (real) namespace and name here
91+
see-also (clj-info/see-also (:ns var-info) (:name var-info))]
9192
(if (seq see-also)
9293
(merge {:see-also see-also} var-info)
9394
var-info)))))

test/clj/cider/nrepl/middleware/info_test.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
(deftest response-test
3434
(let [v (ns-resolve 'cider.nrepl.middleware.info 'assoc)
3535
{:keys [arglists column line added static doc]} (meta v)]
36-
(is (= (dissoc (info/format-response (info/info {:ns "cider.nrepl.middleware.info" :symbol "assoc"})) "file")
36+
(is (= (dissoc (info/format-response (info/info {:ns "cider.nrepl.middleware.info" :symbol "assoc"})) "file" "see-also")
3737
{"ns" "clojure.core"
3838
"name" "assoc"
3939
"arglists-str" (->> (map pr-str arglists)
@@ -256,7 +256,7 @@
256256
(is (= ns "cider.nrepl.middleware.info-test"))))
257257

258258
(testing "see also"
259-
(let [response (session/message {:op "info" :symbol "map" :ns "clojure.core"})]
259+
(let [response (session/message {:op "info" :symbol "map" :ns "cider.nrepl.middleware.info-test"})]
260260
(is (= (:see-also response)
261261
["clojure.core/map-indexed" "clojure.core/pmap" "clojure.core/amap" "clojure.core/mapcat" "clojure.core/keep" "clojure.core/juxt" "clojure.core/mapv" "clojure.core/reduce" "clojure.core/run!"])))
262262
(let [response (session/message {:op "info" :symbol "xyz" :ns "cider.nrepl.middleware.info-test"})]

0 commit comments

Comments
 (0)