[ci] Test against multiple nREPL versions

Author: alexander-yakushev

.circleci/config.yml

@@ -137,14 +137,19 @@ jobs:
       clojure_version:
         description: Version of Clojure to test against
         type: string
+      nrepl_version:
+        description: Version of nREPL to test against
+        type: string
+        default: "1.4"
     executor: << parameters.jdk_version >>
     environment:
       CLOJURE_VERSION: << parameters.clojure_version >>
       JDK_SRC_VERSION: << parameters.jdk_version >>
+      NREPL_VERSION: << parameters.nrepl_version >>
     steps:
       - checkout
       - with_cache:
-          cache_version: "test_v1_<< parameters.clojure_version >>_<< parameters.jdk_version >>"
+          cache_version: "test_v1_<< parameters.clojure_version >>_<< parameters.jdk_version >>_<< parameters.nrepl_version >>"
           steps:
             - run:
                 name: Running quick tests
@@ -209,12 +214,22 @@ workflows:
               clojure_version: ["1.12"]
               jdk_version: [jdk8, jdk25]
           <<: *run_always
+      - test:
+          # Test against multiple nREPL versions.
+          matrix:
+            alias: "nrepl-test"
+            parameters:
+              clojure_version: ["1.12"]
+              jdk_version: [jdk25]
+              nrepl_version: ["1.0", "1.3", "1.4"]
+          <<: *run_always
       - lint:
           <<: *run_always
       - deploy:
           requires:
             - test
             - full-test
+            - nrepl-test
             - lint
           filters:
             branches:

Makefile

@@ -3,9 +3,11 @@
 
 # Set bash instead of sh for the @if [[ conditions,
 # and use the usual safety flags:
-SHELL = /bin/bash -Ee
+SHELL = /bin/bash -Eex
 
 CLOJURE_VERSION ?= 1.12
+NREPL_VERSION ?= 1.4
+COMMON_PROFILES = "+$(CLOJURE_VERSION),+nrepl-$(NREPL_VERSION)"
 TEST_PROFILES ?= "-user,-dev,+test"
 
 # We need Java sources to test Java parsing functionality, but the Docker images
@@ -39,42 +41,40 @@ target/srcdeps: project.clj
 # Remove cljfmt.main because it depends on tools.cli which we explicitly removed.
 	rm -f target/srcdeps/cider/nrepl/inlined/deps/cljfmt/*/cljfmt/main.clj
 
-test_impl: copy-sources-to-jdk
-		lein with-profile $(TEST_PROFILES),+$(CLOJURE_VERSION) test
+quick-test: copy-sources-to-jdk
+	lein with-profile $(COMMON_PROFILES),$(TEST_PROFILES) test
 
 test: target/srcdeps
-	@make test_impl TEST_PROFILES="$(TEST_PROFILES),+plugin.mranderson/config"
-
-quick-test: test_impl
+	lein with-profile $(COMMON_PROFILES),$(TEST_PROFILES),+plugin.mranderson/config test
 
 eastwood:
-	lein with-profile -user,-dev,+$(CLOJURE_VERSION),+deploy,+eastwood eastwood
+	lein with-profile -user,-dev,$(COMMON_PROFILES),+deploy,+eastwood eastwood
 
 cljfmt:
-	lein with-profile -user,-dev,+$(CLOJURE_VERSION),+cljfmt cljfmt check
+	lein with-profile -user,-dev,$(COMMON_PROFILES),+cljfmt cljfmt check
 
 cljfmt-fix:
-	lein with-profile -user,-dev,+$(CLOJURE_VERSION),+cljfmt cljfmt fix
+	lein with-profile -user,-dev,$(COMMON_PROFILES),+cljfmt cljfmt fix
 
 .make_kondo_prep: project.clj .clj-kondo/config.edn
-	CIDER_NO_MRANDERSON="true" CIDER_NO_PEDANTIC="true" lein with-profile -user,-dev,+test,+clj-kondo,+deploy,+$(CLOJURE_VERSION) clj-kondo --copy-configs --dependencies --lint '$$classpath' > $@
+	CIDER_NO_MRANDERSON="true" CIDER_NO_PEDANTIC="true" lein with-profile -user,-dev,+test,+clj-kondo,+deploy,$(COMMON_PROFILES) clj-kondo --copy-configs --dependencies --lint '$$classpath' > $@
 
 kondo: .make_kondo_prep clean
-	CIDER_NO_MRANDERSON="true" CIDER_NO_PEDANTIC="true" lein with-profile -user,-dev,+test,+clj-kondo,+deploy,+$(CLOJURE_VERSION) clj-kondo
+	CIDER_NO_MRANDERSON="true" CIDER_NO_PEDANTIC="true" lein with-profile -user,-dev,+test,+clj-kondo,+deploy,$(COMMON_PROFILES) clj-kondo
 
 lint: kondo cljfmt eastwood
 
 # PROJECT_VERSION=x.y.z make install
 install: dump-version check-install-env target/srcdeps
-	CIDER_NO_PEDANTIC="true" lein with-profile -user,-dev,+$(CLOJURE_VERSION),+plugin.mranderson/config install
+	CIDER_NO_PEDANTIC="true" lein with-profile -user,-dev,$(COMMON_PROFILES),+plugin.mranderson/config install
 
 # PROJECT_VERSION=x.y.z make fast-install
 fast-install: dump-version check-install-env
-	lein with-profile -user,-dev,+$(CLOJURE_VERSION) install
+	lein with-profile -user,-dev,$(COMMON_PROFILES) install
 
 smoketest: install
 	cd test/smoketest && \
-        lein with-profile -user,-dev,+$(CLOJURE_VERSION) uberjar && \
+        lein with-profile -user,-dev,$(COMMON_PROFILES) uberjar && \
         java -jar target/smoketest-0.1.0-SNAPSHOT-standalone.jar
 
 # Deployment is performed via CI by creating a git tag prefixed with "v".
@@ -87,7 +87,7 @@ deploy: check-env target/srcdeps
 	rm -f .no-mranderson
 	export PROJECT_VERSION=$$(echo "$(CIRCLE_TAG)" | sed 's/^v//'); \
 	echo "\"$$PROJECT_VERSION\"" > resources/cider/nrepl/version.edn; \
-	lein with-profile -user,-dev,-provided,+$(CLOJURE_VERSION),+plugin.mranderson/config deploy clojars
+	lein with-profile -user,-dev,-provided,$(COMMON_PROFILES),+plugin.mranderson/config deploy clojars
 
 check-env:
 ifndef CLOJARS_USERNAME

project.clj

@@ -20,8 +20,7 @@
   :license {:name "Eclipse Public License"
             :url "http://www.eclipse.org/legal/epl-v10.html"}
   :scm {:name "git" :url "https://github.com/clojure-emacs/cider-nrepl"}
-  :dependencies [[nrepl/nrepl "1.4.0" :exclusions [org.clojure/clojure]]
-                 [cider/orchard "0.37.0" :exclusions [org.clojure/clojure]]
+  :dependencies [[cider/orchard "0.37.0" :exclusions [org.clojure/clojure]]
                  ^:inline-dep [compliment "0.7.1"]
                  ^:inline-dep [org.rksm/suitable "0.6.2" :exclusions [org.clojure/clojure
                                                                       org.clojure/clojurescript]]
@@ -78,15 +77,20 @@
                                     :password :env/clojars_password
                                     :sign-releases false}]]
 
-  :profiles {:provided {:dependencies [[org.clojure/clojure "1.12.2"]]}
+  :profiles {:provided {:dependencies [[org.clojure/clojure "1.12.3"]
+                                       [nrepl/nrepl "1.4.0" :exclusions [org.clojure/clojure]]]}
 
              :1.10 {:dependencies [[org.clojure/clojure "1.10.3"]
                                    [org.clojure/clojurescript "1.10.520" :scope "provided"]]}
              :1.11 {:dependencies [[org.clojure/clojure "1.11.4"]
                                    [org.clojure/clojurescript "1.11.60" :scope "provided"]]}
-             :1.12 {:dependencies [[org.clojure/clojure "1.12.2"]
+             :1.12 {:dependencies [[org.clojure/clojure "1.12.3"]
                                    [org.clojure/clojurescript "1.12.42" :scope "provided"]]}
 
+             :nrepl-1.0 {:dependencies [[nrepl/nrepl "1.0.0" :exclusions [org.clojure/clojure]]]}
+             :nrepl-1.3 {:dependencies [[nrepl/nrepl "1.3.0" :exclusions [org.clojure/clojure]]]}
+             :nrepl-1.4 {:dependencies [[nrepl/nrepl "1.4.0" :exclusions [org.clojure/clojure]]]}
+
              :maint {:source-paths ["src" "maint"]
                      :dependencies [[org.clojure/tools.cli "1.2.245"]]}
 

test/clj/cider/nrepl_test.clj

@@ -1,9 +1,14 @@
 (ns cider.nrepl-test
   (:require
    [cider.nrepl :as sut]
-   [clojure.test :refer [deftest is testing]]))
+   [clojure.test :refer [deftest is testing]]
+   [nrepl.version]))
 
-(deftest clojure-version-sanity-check
+(deftest versions-sanity-check
   (is (let [v (System/getenv "CLOJURE_VERSION")]
         (println "Running on Clojure" (clojure-version))
-        (or (nil? v) (.startsWith ^String (clojure-version) v)))))
+        (or (nil? v) (.startsWith ^String (clojure-version) v))))
+  (is (let [v (System/getenv "NREPL_VERSION")
+            nver (:version-string nrepl.version/version)]
+        (println "Running on nREPL" nver)
+        (or (nil? v) (.startsWith ^String nver v)))))