Optimize analyze-stacktrace

Author: vemv

CHANGELOG.md

@@ -10,6 +10,10 @@
 
 * Make `middleware.stacktrace` detect a given project's common ns prefix even in face of single-segment namespaces such as `user`.
 
+### Changes
+
+* Parallelize `cider.nrepl.middleware.stacktrace/analyze-stacktrace`.
+
 ## 0.26.0 (2021-04-22)
 
 ### New features

src/cider/nrepl/middleware/stacktrace.clj

@@ -183,9 +183,9 @@
   "Flag the frame if it is from the users project. From a users
   project means that the namespace is one we have identified or it
   begins with the identified common prefix."
-  [{:keys [ns] :as frame}]
+  [namespaces {:keys [ns] :as frame}]
   (if (and ns
-           (or (contains? (directory-namespaces) (symbol ns))
+           (or (contains? namespaces (symbol ns))
                (when (:valid @ns-common-prefix)
                  (.startsWith ^String ns (:common @ns-common-prefix)))))
     (flag-frame frame :project)
@@ -206,15 +206,18 @@
 
 (defn analyze-frame
   "Return the stacktrace as a sequence of maps, each describing a stack frame."
-  [frame]
-  ((comp flag-repl flag-project analyze-fn analyze-file stack-frame) frame))
+  [namespaces frame]
+  (let [f (comp flag-repl (partial flag-project namespaces) analyze-fn analyze-file stack-frame)]
+    (f frame)))
 
 (defn analyze-stacktrace
   "Return the stacktrace as a sequence of maps, each describing a stack frame."
   [^Exception e]
-  (-> (map analyze-frame (.getStackTrace e))
-      (flag-duplicates)
-      (flag-tooling)))
+  (let [namespaces (directory-namespaces)]
+    (-> (pmap (partial analyze-frame namespaces)
+              (.getStackTrace e))
+        (flag-duplicates)
+        (flag-tooling))))
 
 ;;; ## Causes
 

src/cider/nrepl/middleware/test.clj

@@ -57,10 +57,12 @@
 (defn stack-frame
   "Search the stacktrace of exception `e` for the function `f` and return info
   describing the stack frame, including var, class, and line."
-  [^Exception e f]
-  (->> (map st/analyze-frame (.getStackTrace e))
-       (filter #(= (:class %) (.getName (class f))))
-       (first)))
+  ([^Exception e f]
+   (stack-frame (st/directory-namespaces) e f))
+  ([namespaces ^Exception e f]
+   (->> (map (partial st/analyze-frame namespaces) (.getStackTrace e))
+        (filter #(= (:class %) (.getName (class f))))
+        (first))))
 
 (defn- print-object
   "Print `object` using pprint or a custom print-method, if available."
@@ -184,9 +186,10 @@
   finds the erring test fixture in the stacktrace and binds it as the current
   test var. Test count is decremented to indicate that no tests were run."
   [ns e]
-  (let [frame (->> (concat (:clojure.test/once-fixtures (meta ns))
+  (let [namespaces (st/directory-namespaces)
+        frame (->> (concat (:clojure.test/once-fixtures (meta ns))
                            (:clojure.test/each-fixtures (meta ns)))
-                   (map (partial stack-frame e))
+                   (map (partial stack-frame namespaces e))
                    (filter identity)
                    (first))
         fixture (resolve (symbol (:var frame)))]