Skip to content

Commit 966428d

Browse files
committed
Upgrade Orchard, suitable
Increases test coverage now that that upgrade makes it possible.
1 parent 5af614d commit 966428d

File tree

2 files changed

+26
-2
lines changed

2 files changed

+26
-2
lines changed

project.clj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,12 @@
55
:url "http://www.eclipse.org/legal/epl-v10.html"}
66
:scm {:name "git" :url "https://github.com/clojure-emacs/cider-nrepl"}
77
:dependencies [[nrepl "0.8.3"]
8-
^:inline-dep [cider/orchard "0.7.2" :exclusions [com.google.code.findbugs/jsr305 com.google.errorprone/error_prone_annotations]]
8+
^:inline-dep [cider/orchard "0.7.3" :exclusions [com.google.code.findbugs/jsr305 com.google.errorprone/error_prone_annotations]]
99
^:inline-dep [thunknyc/profile "0.5.2"]
1010
^:inline-dep [mvxcvi/puget "1.3.1"]
1111
^:inline-dep [fipp "0.6.24"] ; can be removed in unresolved-tree mode
1212
^:inline-dep [compliment "0.3.11"]
13-
^:inline-dep [org.rksm/suitable "0.4.1-alpha2" :exclusions [org.clojure/clojurescript]]
13+
^:inline-dep [org.rksm/suitable "0.4.1" :exclusions [org.clojure/clojurescript]]
1414
^:inline-dep [cljfmt "0.8.0" :exclusions [org.clojure/clojurescript]]
1515
^:inline-dep [org.clojure/tools.namespace "1.0.0"]
1616
^:inline-dep [org.clojure/tools.trace "0.7.10"]

test/clj/cider/nrepl/middleware/info_test.clj

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,6 +346,18 @@ but `:sym` is unqualified and resolves to a clojure.core var"
346346
(is (= (:status response) #{"done"})
347347
(pr-str response))))
348348

349+
(testing "info does not return a no-info packet if ns not found,
350+
but `:sym` is qualified and resolves to a clojure.core var"
351+
(let [response (session/message {:op "info" :sym "clojure.core/+" :ns "fakefakefake"})]
352+
(is (= (:status response) #{"done"})
353+
(pr-str response))))
354+
355+
(testing "info does not return a no-info packet if ns not found,
356+
but `:sym` is qualified and resolves to a clojure.string var"
357+
(let [response (session/message {:op "info" :sym "clojure.string/replace" :ns "fakefakefake"})]
358+
(is (= (:status response) #{"done"})
359+
(pr-str response))))
360+
349361
(testing "ensure info returns a no-info packet if class not found"
350362
(let [response (session/message {:op "info" :class "awoeijfxcvb" :member "toString"})]
351363
(is (= (:status response) #{"no-info" "done"})
@@ -368,6 +380,18 @@ but `:sym` is unqualified and resolves to a clojure.core var"
368380
(is (= (:status response) #{"done"})
369381
(pr-str response))))
370382

383+
(testing "eldoc does not return a no-eldoc packet if ns not found,
384+
but `:sym` is qualified and resolves to a clojure.core var"
385+
(let [response (session/message {:op "eldoc" :sym "clojure.core/+" :ns "fakefakefake"})]
386+
(is (= (:status response) #{"done"})
387+
(pr-str response))))
388+
389+
(testing "eldoc does not return a no-eldoc packet if ns not found,
390+
but `:sym` is qualified and resolves to a clojure.string var"
391+
(let [response (session/message {:op "eldoc" :sym "clojure.string/replace" :ns "fakefakefake"})]
392+
(is (= (:status response) #{"done"})
393+
(pr-str response))))
394+
371395
(testing "ensure eldoc returns a no-eldoc packet if class not found"
372396
(let [response (session/message {:op "eldoc" :class "awoeijfxcvb" :member "toString"})]
373397
(is (= (:status response) #{"no-eldoc" "done"})

0 commit comments

Comments
 (0)