Filter non file urls from classpath response (#667)

Not all urls on a classpath are necessarily files. Eg. spring boot
adds "jar:file:..." urls

Co-authored-by: Bozhidar Batsov <[email protected]>

Author: fp7

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+### Bugs fixed
+
+* [#667](https://github.com/clojure-emacs/cider-nrepl/pull/667): Filter non file urls from classpath response.
+
 ## 0.25.2 (2020-06-07)
 
 ### Bugs fixed

src/cider/nrepl/middleware/classpath.clj

@@ -2,10 +2,17 @@
   (:require
    [cider.nrepl.middleware.util.error-handling :refer [with-safe-transport]]
    [clojure.java.io :as io]
-   [orchard.java.classpath :as cp]))
+   [orchard.java.classpath :as cp]
+   [orchard.misc :as misc]))
+
+(defn file-url?
+  [u]
+  (and (misc/url? u)
+       (= (.getProtocol ^java.net.URL u) "file")))
 
 (defn classpath-reply [msg]
   {:classpath (->> (cp/classpath)
+                   (filter file-url?)
                    (map io/as-file)
                    (map str))})
 

test/clj/cider/nrepl/middleware/classpath_test.clj

@@ -21,3 +21,7 @@
       (is (.startsWith (:err response) "java.lang.Exception: cp error"))
       (is (= (:ex response) "class java.lang.Exception"))
       (is (:pp-stacktrace response)))))
+
+(deftest file-url?-test
+  (is (file-url? (.toURL (.toURI (java.io.File. "")))))
+  (is (not (file-url? (java.net.URL. "jar:file:/tmp/test.jar!/BOOT-INF/classes")))))