Skip to content

Commit e8f857b

Browse files
committed
Use nrepl.middleware.caught
1 parent e53fa56 commit e8f857b

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/cider/nrepl.clj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
[cider.nrepl.middleware.pprint :as pprint]
66
[cider.nrepl.print-method]
77
[nrepl.middleware :refer [set-descriptor!]]
8+
[nrepl.middleware.caught :refer [wrap-caught]]
89
[nrepl.middleware.session :refer [session]]
910
[nrepl.middleware.pr-values :refer [pr-values]]
1011
[nrepl.server :as nrepl-server]))
@@ -228,7 +229,7 @@
228229
in the `:inspect` slot will cause the last value returned by eval to
229230
be inspected. Returns a string representation of the resulting
230231
inspector's state in the `:value` slot."
231-
:requires #{"clone" #'pr-values}
232+
:requires #{"clone" #'pr-values #'wrap-caught}
232233
:expects #{"eval"}
233234
:handles {"inspect-pop"
234235
{:doc "Moves one level up in the inspector stack."

src/cider/nrepl/middleware/inspect.clj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
[cider.nrepl.middleware.util.cljs :as cljs]
44
[cider.nrepl.middleware.util.error-handling :refer [base-error-response
55
with-safe-transport]]
6+
[nrepl.middleware.caught :as caught]
67
[nrepl.misc :refer [response-for]]
78
[nrepl.transport :as transport]
89
[orchard.inspect :as inspect])
@@ -40,9 +41,9 @@
4041
;; If the eval errored, propagate the exception as error in the
4142
;; inspector middleware, so that the client CIDER code properly
4243
;; renders it instead of silently ignoring it.
43-
(contains? (:status response) :eval-error)
44-
(let [e (or (@session #'*e)
45-
(Exception. (or (:ex response) "")))
44+
(and (contains? (:status response) :eval-error)
45+
(contains? response ::caught/throwable))
46+
(let [e (::caught/throwable response)
4647
resp (base-error-response msg e :inspect-eval-error :done)]
4748
(.send transport resp))
4849

0 commit comments

Comments
 (0)