Deprecate the pprint middleware

Author: bbatsov

CHANGELOG.md

@@ -6,6 +6,7 @@
 
 * **(Breaking)** Drop support for nREPL 0.2.x (aka `tools.nrepl`). Now nREPL 0.4+ is required.
 * **(Breaking)** Drop support for Piggieback 0.2.x (aka `cemerick.piggieback`).  Now Piggieback 0.3+ is required.
+* Deprecated `cider.nrepl.middleware.pprint` if favour of the built-in pprint support in nREPL 0.5.
 
 ## 0.19.0 (2019-01-01)
 

README.md

@@ -130,8 +130,6 @@ under `:repl-options`.
                   cider.nrepl/wrap-macroexpand
                   cider.nrepl/wrap-ns
                   cider.nrepl/wrap-spec
-                  cider.nrepl/wrap-pprint
-                  cider.nrepl/wrap-pprint-fn
                   cider.nrepl/wrap-profile
                   cider.nrepl/wrap-refresh
                   cider.nrepl/wrap-resource
@@ -269,9 +267,9 @@ Middleware        | Op(s)      | Description
 `wrap-inspect`    |`inspect-(start/refresh/pop/push/reset/get-path)` | Inspect a Clojure expression.
 `wrap-macroexpand`| `macroexpand/macroexpand-1/macroexpand-all/macroexpand-step` | Macroexpand a Clojure form.
 `wrap-ns`         | `ns-list/ns-vars/ns-path/ns-load-all/ns-aliases` | Namespace browsing & loading.
-`wrap-spec`         | `spec-list/spec-form/spec-example` | Spec browsing.
-`wrap-pprint`     | | Adds pretty-printing support to code evaluation. It also installs a dummy `pprint-middleware` op. Thus `wrap-pprint` is discoverable through the `describe` op.
-`wrap-pprint-fn`  | | Provides a common pretty-printing interface for other middlewares that need to perform customisable pretty-printing.
+`wrap-spec`       | `spec-list/spec-form/spec-example` | Spec browsing.
+`wrap-pprint`     | - | **(DEPRECATED)** Adds pretty-printing support to code evaluation. It also installs a dummy `pprint-middleware` op. Thus `wrap-pprint` is discoverable through the `describe` op.
+`wrap-pprint-fn`  | - | **(DEPRECATED)** Provides a common pretty-printing interface for other middlewares that need to perform customisable pretty-printing.
 `wrap-profile`    | `toggle-profile/toggle-profile-ns/is-var-profiled/profile-summary/profile-var-summary/clear-profile/get-max-samples/set-max-samples` | Provides profiling support based on the [profile](https://github.com/thunknyc/profile) library.
 `wrap-refresh`    | `refresh/refresh-all/refresh-clear` | Code reloading.
 `wrap-resource`   | `resource` | Return resource path.

src/cider/nrepl/middleware/pprint.clj

@@ -11,7 +11,11 @@
   (:import
    nrepl.transport.Transport))
 
-;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;; DEPRECATED in favour of the built-in pprint support added in nREPL 0.5 ;;
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+
+;; TODO: Remove this middleware (or make it a no-op).
 
 ;; fipp-printer and puget-printer are not loaded in the main `(ns)` form
 ;; because they are optional features that take hundreds of milliseconds