Fix clj-kondo warnings

Author: solar05

.clj-kondo/config.edn

@@ -0,0 +1,9 @@
+{:linters {:unresolved-symbol {:exclude [(cider.nrepl/def-wrapper)
+                                         (cider.nrepl.middleware.util.instrument/definstrumenter)
+                                         (cider.nrepl.middleware.util.instrument/with-break)
+                                         (cider.nrepl.middleware.util.instrument/instrument-special-form)
+                                         (cider.nrepl.middleware.util.instrument/instrument-coll)
+                                         (cider.nrepl.print-method/def-print-method)]}
+           :unresolved-namespace {:exclude [clojure.main]}}
+ :output {:progress true
+          :exclude-files ["data_readers" "tasks"]}}

.gitignore

@@ -17,3 +17,4 @@ out
 .lein-repl-history
 .nrepl-port
 .source-deps
+.clj-kondo/.cache

src/cider/nrepl/middleware/classpath.clj

@@ -10,7 +10,7 @@
   (and (misc/url? u)
        (= (.getProtocol ^java.net.URL u) "file")))
 
-(defn classpath-reply [msg]
+(defn classpath-reply [_msg]
   {:classpath (->> (cp/classpath)
                    (filter file-url?)
                    (map io/as-file)

src/cider/nrepl/middleware/complete.clj

@@ -27,7 +27,7 @@
   [::suitable-sources/cljs-source])
 
 (defn complete
-  [{:keys [ns prefix symbol context extra-metadata enhanced-cljs-completion?] :as msg}]
+  [{:keys [ns prefix symbol context extra-metadata] :as msg}]
   ;; TODO: Drop legacy symbol param in version 1.0
   (let [prefix (str (or prefix symbol))
         completion-opts {:ns (misc/as-sym ns)
@@ -56,7 +56,7 @@
   {:completion-doc (completion-doc msg)})
 
 (defn flush-caches-reply
-  [msg]
+  [_msg]
   (complete-utils/flush-caches)
   {})
 

src/cider/nrepl/middleware/content_type.clj

@@ -45,7 +45,6 @@
   (:require
    [cider.nrepl.middleware.slurp :refer [slurp-reply]])
   (:import
-   java.awt.Image
    [java.awt.image RenderedImage]
    [java.io ByteArrayOutputStream File OutputStream]
    [java.net URI URL]
@@ -80,7 +79,7 @@
   recognized as an AWT Image, a File, or a File URI, rewrite the
   response to have a `:content-type` being a MIME type of the content,
   and a `:body` to re-use the RFC term for the message payload."
-  [{:keys [session value] :as response}]
+  [{:keys [value] :as response}]
   (cond
     ;; FIXME (arrdem 2018-04-03):
     ;;

src/cider/nrepl/middleware/debug.clj

@@ -10,7 +10,6 @@
    [cider.nrepl.middleware.util.nrepl :refer [notify-client]]
    [nrepl.middleware.interruptible-eval :refer [*msg*]]
    [nrepl.middleware.print :as print]
-   [nrepl.middleware.session :as session]
    [nrepl.misc :refer [response-for]]
    [nrepl.transport :as transport]
    [orchard.info :as info]
@@ -624,7 +623,7 @@ this map (identified by a key), and will `dissoc` it afterwards."}
         ;; new-line in REPL always throws; skip for debug convenience
         (when (> (count code) 3)
           (read-string {:read-cond :allow} code))
-        (catch Exception e)))
+        (catch Exception _e)))
     (if @has-debug?
       ;; Technically, `instrument-and-eval` acts like a regular eval
       ;; if there are no debugging macros. But we still only use it

src/cider/nrepl/middleware/enlighten.clj

@@ -32,7 +32,7 @@
   Currently this only instruments forms that could run several times
   in a single evaluation. This is necessary so that the client can
   clean-up overlays from previous evaluations."
-  [[head & args :as form] {:keys [coor] :as extras}]
+  [[head & args :as form] {:keys [coor]}]
   (let [erase `(d/debugger-send (assoc (:msg ~'STATE__)
                                        :coor ~coor
                                        :status :enlighten

src/cider/nrepl/middleware/format.clj

@@ -26,7 +26,7 @@
    indents))
 
 (defn format-code-reply
-  [{:keys [code options] :as msg}]
+  [{:keys [code options]}]
   (let [opts (some-> options
                      (select-keys [:indents :alias-map])
                      (update :indents generate-user-indents)
@@ -56,7 +56,7 @@
        (str/trim)))
 
 (defn format-edn-reply
-  [{:keys [edn ::print/print-fn] :as msg}]
+  [{:keys [edn ::print/print-fn]}]
   {:formatted-edn (format-edn edn print-fn)})
 
 ;;; Middleware op handling

src/cider/nrepl/middleware/info.clj

@@ -3,7 +3,6 @@
    [cider.nrepl.middleware.util :as util]
    [cider.nrepl.middleware.util.cljs :as cljs]
    [cider.nrepl.middleware.util.error-handling :refer [with-safe-transport]]
-   [clojure.java.io :as io]
    [clojure.string :as str]
    [orchard.eldoc :as eldoc]
    [orchard.info :as info]
@@ -87,7 +86,7 @@
     {:status :no-eldoc}))
 
 (defn eldoc-datomic-query-reply
-  [{:keys [ns sym symbol] :as msg}]
+  [{:keys [ns sym symbol]}]
   (try
     (eldoc/datomic-query ns (or sym symbol))
     (catch Throwable _ {:status :no-eldoc})))

src/cider/nrepl/middleware/inspect.clj

@@ -11,15 +11,15 @@
    nrepl.transport.Transport))
 
 (defn swap-inspector!
-  [{:keys [session] :as msg} f & args]
+  [{:keys [session]} f & args]
   (-> session
       (alter-meta! update ::inspector #(apply f % args))
       (get ::inspector)))
 
 (defn- inspector-response
   ([msg inspector]
    (inspector-response msg inspector {:status :done}))
-  ([msg {:keys [rendered] :as inspector} resp]
+  ([msg {:keys [rendered]} resp]
    (let [value (binding [*print-length* nil]
                  (pr-str rendered))]
      (response-for msg resp {:value value}))))
@@ -33,7 +33,7 @@
     (transport/send transport (inspector-response msg inspector {}))))
 
 (defn inspector-transport
-  [{:keys [^Transport transport, session] :as msg}]
+  [{:keys [^Transport transport] :as msg}]
   (reify Transport
     (recv [this] (.recv transport))
     (recv [this timeout] (.recv transport timeout))
@@ -72,7 +72,7 @@
 (defn refresh-reply [msg]
   (inspector-response msg (swap-inspector! msg #(or % (inspect/fresh)))))
 
-(defn get-path-reply [{:keys [session] :as msg}]
+(defn get-path-reply [{:keys [session]}]
   (get-in (meta session) [::inspector :path]))
 
 (defn next-page-reply [msg]