Refactor cider-current-connection

* repls -> project-connections
* Fix considering all connections in the branch for project
  connections.

AFAICT this only worked correctly because of the order in the list being
checked.

Author: expez

cider-client.el

@@ -207,21 +207,22 @@ from the file extension."
   (cider-connections) ; Cleanup the connections list.
   (if (eq cider-request-dispatch 'dynamic)
       (cond
-       ((cider--in-connection-buffer-p) (current-buffer))
+       ((and (not type) (cider--in-connection-buffer-p)) (current-buffer))
        ((= 1 (length cider-connections)) (car cider-connections))
-       (t (let ((repls (cider-find-connection-buffer-for-project-directory
-                        nil :all-connections)))
-            (if (= 1 (length repls))
+       (t (let ((project-connections
+                 (cider-find-connection-buffer-for-project-directory
+                  nil :all-connections)))
+            (if (= 1 (length project-connections))
                 ;; Only one match, just return it.
-                (car repls)
+                (car project-connections)
               ;; OW, find one matching the extension of current file.
               (let ((type (or type (file-name-extension (or (buffer-file-name) "")))))
                 (or (seq-find (lambda (conn)
                                 (equal (with-current-buffer conn
                                          cider-repl-type)
                                        type))
-                              (append repls cider-connections))
-                    (car repls)
+                              project-connections)
+                    (car project-connections)
                     (car cider-connections)))))))
     ;; TODO: Add logic to dispatch to a matching Clojure/ClojureScript REPL based on file type
     (car cider-connections)))