Replace a few occurrences of when + not with unless

Author: bbatsov

cider-repl-history.el

@@ -615,7 +615,7 @@ text from the *cider-repl-history* buffer."
                              #'copy-sequence
                            #'substring-no-properties)
                          cider-command-history)))
-            (when (not cider-repl-history-display-duplicates)
+            (unless cider-repl-history-display-duplicates
               ;; display highest or lowest duplicate.
               ;; if `cider-repl-history-display-duplicate-highest' is t,
               ;; display highest (most recent) duplicate.

cider.el

@@ -348,7 +348,7 @@ string is quoted for passing as argument to an inferior shell."
 (defun cider-boot-dependencies (dependencies)
   "Return a list of boot artifact strings created from DEPENDENCIES."
   (concat (mapconcat #'cider--list-as-boot-artifact dependencies " ")
-          (when (not (seq-empty-p dependencies)) " ")))
+          (unless (seq-empty-p dependencies) " ")))
 
 (defun cider-boot-middleware-task (params middlewares)
   "Create a command to add MIDDLEWARES with corresponding PARAMS."
@@ -366,7 +366,7 @@ PLUGINS and MIDDLEWARES.  PARAMS and MIDDLEWARES are passed on to
 `cider-boot-middleware-task` before concatenating and DEPENDENCIES and PLUGINS
  are passed on to `cider-boot-dependencies`."
   (concat global-opts
-          (when (not (seq-empty-p global-opts)) " ")
+          (unless (seq-empty-p global-opts) " ")
           "-i \"(require 'cider.tasks)\" " ;; Note the white space at the end here
           (cider-boot-dependencies (append dependencies plugins))
           (cider-boot-middleware-task params middlewares)))
@@ -390,7 +390,7 @@ Does so by concatenating GLOBAL-OPTS, DEPENDENCIES, with DEPENDENCIES-EXCLUSIONS
 removed, LEIN-PLUGINS, and finally PARAMS."
   (concat
    global-opts
-   (when (not (seq-empty-p global-opts)) " ")
+   (unless (seq-empty-p global-opts) " ")
    (mapconcat #'identity
               (append (seq-map (lambda (dep)
                                  (let ((exclusions (cadr (assoc (car dep) dependencies-exclusions))))
@@ -447,7 +447,7 @@ dependencies."
              cider-jack-in-nrepl-middlewares))
     ("gradle" (concat
                global-opts
-               (when (not (seq-empty-p global-opts)) " ")
+               (unless (seq-empty-p global-opts) " ")
                params))
     (_ (error "Unsupported project type `%s'" project-type))))
 

nrepl-client.el

@@ -545,9 +545,9 @@ key-values depending on the connection type."
 If NO-ERROR is non-nil, show messages instead of throwing an error."
   (if (not (and host port))
       (unless no-error
-        (when (not host)
+        (unless host
           (error "[nREPL] Host not provided"))
-        (when (not port)
+        (unless port
           (error "[nREPL] Port not provided")))
     (message "[nREPL] Establishing direct connection to %s:%s ..." host port)
     (condition-case nil

test/cider-tests--no-auto.el

@@ -85,7 +85,7 @@ from the latter. Remaining content is compared for string equality."
         (let ((name (cond ((symbolp sym) (symbol-name sym))
                           ((listp sym) (symbol-name (cadr sym))))))
           (if name
-              (when (not (cider-test-doc name))
+              (unless (cider-test-doc name)
                 (setq diffs (cons sym diffs)))
             (setq untested (cons sym untested)))))
       (when untested