fixup - don't show overlay on errors in REPL buffer

Author: alexander-yakushev

cider-eval.el

@@ -365,10 +365,16 @@ For others, pop up *cider-error* buffer."
    causes nil (member ex-phase (cider-clojure-compilation-error-phases)))
   ;; If the error is a compilation error (which we normally don't show
   ;; *cider-error* buffer for), or the error buffer is disabled, compensate for
-  ;; the lack of info with a overlay error.
-  (when (or (member ex-phase (cider-clojure-compilation-error-phases))
-            (not (cider--show-error-buffer-p))
-            (not (cider-connection-has-capability-p 'jvm-compilation-errors)))
+  ;; the lack of info with a overlay error. Verify that the provided buffer is
+  ;; visiting a source file.
+  (when (and code-buffer
+             (with-current-buffer code-buffer
+               (or (cider-clojure-major-mode-p)
+                   (cider-clojurec-major-mode-p)
+                   (cider-clojurescript-major-mode-p)))
+             (or (member ex-phase (cider-clojure-compilation-error-phases))
+                 (not (cider--show-error-buffer-p))
+                 (not (cider-connection-has-capability-p 'jvm-compilation-errors))))
     ;; Search if any of the received causes contains a "triage" field. Append it
     ;; to the inline error message if found.
     (let* ((triage (seq-some (lambda (cause) (nrepl-dict-get cause "triage")) causes))
@@ -379,7 +385,6 @@ For others, pop up *cider-error* buffer."
                           err-message)))
       (cider--display-error-unobtrusively code-buffer err-message))))
 
-
 (defun cider--analyze-last-stacktrace (callback)
   "Send `analyze-last-stacktrace' to server and invoke CALLBACK on the result.
 Accumulates a list of causes and then calls CALLBACK on causes and phase."
@@ -402,7 +407,7 @@ Show error overlay in BUFFER if needed."
   (cider--analyze-last-stacktrace
    (lambda (causes phase) (cider--handle-stacktrace-response causes phase buffer))))
 
-(defun cider-default-err-handler (buffer)
+(defun cider-default-err-handler (&optional buffer)
   "This function determines how the error buffer is shown.
 It delegates the actual error content to the eval or op handler.
 Show error overlay in BUFFER if needed."