Skip to content

Commit 44a7ced

Browse files
jeffvalkcap10morgan
authored andcommitted
[Fix #1435] Display test results more specifically
Requires clojure-emacs/cider-nrepl@abc6c2b
1 parent a54f613 commit 44a7ced

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
* [#1486](https://github.com/clojure-emacs/cider/issues/1486): Complete a partial fix in stacktrace font-locking.
1717
* [#1488](https://github.com/clojure-emacs/cider/pull/1488): Delete zombie overlays in the REPL buffer.
1818
* [#1482](https://github.com/clojure-emacs/cider/issues/1482): Clear nREPL sessions when a connection is closed.
19+
* [#1435](https://github.com/clojure-emacs/cider/issues/1435): Improve error display is cider-test.
1920

2021
## 0.10.0 / 2015-12-03
2122

cider-test.el

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -287,18 +287,20 @@ With the actual value, the outermost '(not ...)' s-expression is removed."
287287
(cider-insert var 'font-lock-function-name-face t)
288288
(when context (cider-insert context 'font-lock-doc-face t))
289289
(when message (cider-insert message 'font-lock-doc-string-face t))
290-
(when expected (cider-insert "expected: " 'font-lock-comment-face nil
291-
(cider-font-lock-as-clojure expected)))
292-
(when actual (cider-insert " actual: " 'font-lock-comment-face)
293-
(if error
294-
(progn (insert-text-button
295-
error
296-
'follow-link t
297-
'action '(lambda (_button) (cider-test-stacktrace))
298-
'help-echo "View causes and stacktrace")
299-
(insert "\n"))
300-
(insert (cider-font-lock-as-clojure actual)))))
301-
(insert "\n"))))
290+
(when expected
291+
(cider-insert "expected: " 'font-lock-comment-face nil
292+
(cider-font-lock-as-clojure expected)))
293+
(when actual
294+
(cider-insert " actual: " 'font-lock-comment-face nil
295+
(cider-font-lock-as-clojure actual)))
296+
(when error
297+
(cider-insert " error: " 'font-lock-comment-face nil)
298+
(insert-text-button error
299+
'follow-link t
300+
'action '(lambda (_button) (cider-test-stacktrace))
301+
'help-echo "View causes and stacktrace")
302+
(insert "\n"))
303+
(insert "\n")))))
302304

303305
(defun cider-test-render-report (buffer ns summary results)
304306
"Emit into BUFFER the report for the NS, SUMMARY, and test RESULTS."

0 commit comments

Comments
 (0)