[Fix #1823] Properly set the column metadata on interactive evaluation

Basically the issue was coming from the fact that Clojure counts columns
from 1 and Emacs from 0.

Somewhat amusing Emacs counts lines from 1, not 0.

Author: bbatsov

CHANGELOG.md

@@ -22,6 +22,7 @@ within the scope of your current Emacs session.
 * [#1819](https://github.com/clojure-emacs/cider/issues/1819): Handle properly missing commands on `cider-jack-in`.
 * Add option to define exclusions for injected dependecies. Fixes [#1824](https://github.com/clojure-emacs/cider/issues/1824): Can no longer jack-in to an inherited clojure version.
 * [#1820](https://github.com/clojure-emacs/cider/issues/1820): Don't try to display eldoc in EDN buffers.
+* [#1823](https://github.com/clojure-emacs/cider/issues/1823): Fix column location metadata set by interactive evaluation.
 
 ## 0.13.0 (2016-07-25)
 

cider-util.el

@@ -662,7 +662,11 @@ through a stack of help buffers.  Variables `help-back-label' and
 (defun cider-column-number-at-pos (pos)
   "Analog to `line-number-at-pos'.
 Return buffer column number at position POS."
-  (save-excursion (goto-char pos) (current-column)))
+  (save-excursion
+    (goto-char pos)
+    ;; we have to adjust the column number by 1 to account for the fact
+    ;; that Emacs starts counting columns from 0 and Clojure from 1
+    (1+ (current-column))))
 
 (defun cider-propertize (text kind)
   "Propertize TEXT as KIND.