Skip to content

Commit 5e19be0

Browse files
author
Bozhidar Batsov
committed
Update grimoire URL generation for grimoire 0.3
Reference - arrdem/clojure-cheatsheets@f84a3bf
1 parent c209d8a commit 5e19be0

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

cider-interaction.el

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1415,9 +1415,8 @@ under point, prompts for a var."
14151415
"Convert the dashes in NAME to a grimoire friendly format."
14161416
(->> name
14171417
(replace-regexp-in-string "\\?" "_QMARK_")
1418-
(replace-regexp-in-string "!" "_BANG_")
1419-
(replace-regexp-in-string "\\*" "_STAR_")
1420-
(replace-regexp-in-string "\\-" "_DASH_")
1418+
(replace-regexp-in-string "\\." "_DOT_")
1419+
(replace-regexp-in-string "\\/" "_SLASH_")
14211420
(replace-regexp-in-string "\\(\\`_\\)\\|\\(_\\'\\)" "")))
14221421

14231422
(defun cider-grimoire-url (name ns clojure-version)

test/cider-tests.el

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -546,15 +546,13 @@
546546
;;; grimoire tests
547547
(ert-deftest cider-grimoire-replace-special ()
548548
(should (equal (cider-grimoire-replace-special "isa?") "isa_QMARK"))
549-
(should (equal (cider-grimoire-replace-special "really-isa?") "really_DASH_isa_QMARK"))
550-
(should (equal (cider-grimoire-replace-special "reset!") "reset_BANG"))
551-
(should (equal (cider-grimoire-replace-special "*ns*") "STAR_ns_STAR"))
552-
(should (equal (cider-grimoire-replace-special "defn-") "defn_DASH"))
553-
(should (equal (cider-grimoire-replace-special "-map-indexed") "DASH_map_DASH_indexed"))
554-
(should (equal (cider-grimoire-replace-special "-foo-bar-baz-") "DASH_foo_DASH_bar_DASH_baz_DASH")))
549+
(should (equal (cider-grimoire-replace-special "really-isa?") "really-isa_QMARK"))
550+
(should (equal (cider-grimoire-replace-special "..") "DOT__DOT"))
551+
(should (equal (cider-grimoire-replace-special ".") "DOT"))
552+
(should (equal (cider-grimoire-replace-special "/") "SLASH")))
555553

556554
(ert-deftest cider-grimoire-url ()
557-
(should (equal "http://grimoire.arrdem.com/1.5.0/clojure.core/defn_DASH/"
558-
(cider-grimoire-url "defn-" "clojure.core" "1.5.1")))
555+
(should (equal "http://grimoire.arrdem.com/1.5.0/clojure.core/even_QMARK/"
556+
(cider-grimoire-url "even?" "clojure.core" "1.5.1")))
559557
(should (equal "http://grimoire.arrdem.com/1.5.0/clojure.core/"
560558
(cider-grimoire-url nil "clojure.core" "1.5.1"))))

0 commit comments

Comments
 (0)