Check the entire classpath for files to save before refreshing

Previously this relied on `clojure-project-dir` from clojure-mode, but
tools.namespace will refresh any modified files on the entire classpath, so they
are worth including too.

Additionally, path comparisons are now made using `file-in-directory-p` rather
than `string-prefix-p`, obviating any issues around path expansion, symlinks,
and platform-specific issues such as case sensitivity.

Author: cichli

CHANGELOG.md

@@ -5,10 +5,11 @@
 ### New features
 
 ### Changes
-* Fix values for `cider-preferred-build-tool` variable.
-* Fix value and safe property for `cider-allow-jack-in-without-project` variable.
 
 ### Bug fixes
+* Fix values for `cider-preferred-build-tool` variable.
+* Fix value and safe property for `cider-allow-jack-in-without-project` variable.
+* `cider-ns-save-files-on-refresh` will now save any modified buffers visiting files on the classpath, rather than just in the current project.
 
 ## 0.20.0 (2019-01-14)
 
@@ -40,6 +41,7 @@
 
 ### Bug fixes
 
+* `cider-expected-ns` no longer requires an absolute path as its argument, and now internally handles paths canonically and consistently.
 * [#2474](https://github.com/clojure-emacs/cider/issues/2474): Fix incorrect detection of output and out-of-order printing.
 * [#2514](https://github.com/clojure-emacs/cider/issues/2514): Don't auto-jump to warnings when `cider-auto-jump-to-error` is set to 'errors-only.
 * [#2453](https://github.com/clojure-emacs/cider/issues/2453): Make it possible to debug deftype methods by direct insertion of #dbg and #break readers into the deftype methods.

cider-ns.el

@@ -161,19 +161,19 @@ namespace-qualified function of zero arity."
     (when (member "error" status)
       (cider--render-stacktrace-causes error))))
 
-(defun cider-ns-refresh--save-project-buffers ()
-  "Ensure modified project buffers are saved before certain operations.
+(defun cider-ns-refresh--save-modified-buffers ()
+  "Ensure any relevant modified buffers are saved before refreshing.
 Its behavior is controlled by `cider-save-files-on-cider-ns-refresh'."
-  (when-let* ((project-root (clojure-project-dir)))
-    (when cider-save-files-on-cider-ns-refresh
+  (when cider-save-files-on-cider-ns-refresh
+    (let ((dirs (seq-filter #'file-directory-p
+                            (cider-sync-request:classpath))))
       (save-some-buffers
-       (eq cider-save-files-on-cider-ns-refresh t)
+       (not (eq cider-save-files-on-cider-ns-refresh 'prompt))
        (lambda ()
-         (and
-          (derived-mode-p 'clojure-mode)
-          (string-prefix-p project-root
-                           (file-truename default-directory)
-                           (eq system-type 'windows-nt))))))))
+         (and (derived-mode-p 'clojure-mode)
+              (seq-some (lambda (dir)
+                          (file-in-directory-p buffer-file-name dir))
+                        dirs)))))))
 
 ;;;###autoload
 (defun cider-ns-reload (&optional prompt)
@@ -226,7 +226,7 @@ refresh functions (defined in `cider-ns-refresh-before-fn' and
   (interactive "p")
   (cider-ensure-connected)
   (cider-ensure-op-supported "refresh")
-  (cider-ns-refresh--save-project-buffers)
+  (cider-ns-refresh--save-modified-buffers)
   (let ((clear? (member mode '(clear 16)))
         (refresh-all? (member mode '(refresh-all 4)))
         (inhibit-refresh-fns (member mode '(inhibit-fns -1))))