Set cider-prompt-for-symbol to nil by default

That was requested numerous times and I feel it makes for a better
default.

Author: bbatsov

CHANGELOG.md

@@ -15,6 +15,7 @@
 * Bump the injected nREPL version to 0.8.1.
 * Bump the injected `cider-nrepl` version to `0.25.4`.
 * [#2897](https://github.com/clojure-emacs/cider/pull/2897): Translate paths from CIDER to nREPL and vice-versa.
+* Set `cider-prompt-for-symbol` to `nil` by default.
 
 ## 0.26.1 (2020-08-14)
 

cider-common.el

@@ -31,7 +31,7 @@
 (require 'etags) ; for find-tags-marker-ring
 (require 'tramp)
 
-(defcustom cider-prompt-for-symbol t
+(defcustom cider-prompt-for-symbol nil
   "Controls when to prompt for symbol when a command requires one.
 
 When non-nil, always prompt, and use the symbol at point as the default

doc/modules/ROOT/pages/config/basic_config.adoc

@@ -27,20 +27,31 @@ buffers. You can override this behavior, however:
 (setq cider-auto-mode nil)
 ----
 
-== Disable Symbol Confirmation
+== Prompt for Symbol Confirmation
 
-By default, CIDER prompts you for a symbol when it executes
-interactive commands that require a symbol (e.g. `cider-doc`). The
-default symbol will be the one at point. If you set
-`cider-prompt-for-symbol` to `nil`, CIDER will try the symbol at point
-first, and only prompt if that fails (this was the behavior in older
-CIDER releases).
+NOTE: The default here was changed in CIDER 1.0.
+
+By default, CIDER won't prompt you for a symbol when it executes
+interactive commands that require a symbol (e.g. `cider-doc`). Such
+commands operate on the symbol at point and prompt you to provide
+a symbol if they can't obtain one automatically.
+
+If you set
+`cider-prompt-for-symbol` to `t`, this behavior will be inverted and
+CIDER will always prompt you to confirm the symbol on which a command
+will operate. This behavior is useful, as it allows you to edit the
+inferred symbol, before some operation is carried out with it (and you get to
+see what was inferred by `cider-symbol-at-point`).
 
 [source,lisp]
 ----
-(setq cider-prompt-for-symbol nil)
+(setq cider-prompt-for-symbol t)
 ----
 
+TIP: Many interactive commands that operate on the symbol at point,
+accept a prefix argument that flips the behavior configured via
+`cider-prompt-for-symbol` for the current command invocation.
+
 == Control what window to use when jumping to a definition
 
 By default kbd:[M-.] and other commands that jump to a definition have the following behavior:

doc/modules/ROOT/pages/usage/cider_mode.adoc

@@ -168,22 +168,22 @@ kbd:[C-u C-c C-c]
 | `cider-doc`
 | kbd:[C-c C-d d] +
 kbd:[C-c C-d C-d]
-| Display doc string for the symbol at point.  If invoked with a prefix argument, or no symbol is found at point, prompt for a symbol.
+| Display doc string for the symbol at point.  If invoked with a prefix argument it inverts the value of `cider-prompt-for-symbol`.
 
 | `cider-javadoc`
 | kbd:[C-c C-d j] +
 kbd:[C-c C-d C-j]
-| Display JavaDoc (in your default browser) for the symbol at point.  If invoked with a prefix argument, or no symbol is found at point, prompt for a symbol.
+| Display JavaDoc (in your default browser) for the symbol at point.  If invoked with a prefix argument it inverts the value of `cider-prompt-for-symbol`.
 
 | `cider-clojuredocs`
 | kbd:[C-c C-d c] +
 kbd:[C-c C-d C-c]
-| Lookup symbol in ClojureDocs.
+| Lookup symbol in ClojureDocs. If invoked with a prefix argument it inverts the value of `cider-prompt-for-symbol`.
 
 | `cider-clojuredocs-web`
 | kbd:[C-c C-d w] +
 kbd:[C-c C-d C-w]
-| Open the ClojureDocs documentation for symbol in a web browser.
+| Open the ClojureDocs documentation for symbol in a web browser. If invoked with a prefix argument it inverts the value of `cider-prompt-for-symbol`.
 
 | `cider-apropos`
 | kbd:[C-c C-d a] +
@@ -206,15 +206,15 @@ kbd:[C-c C-d C-e]
 
 | `cider-toggle-trace-var`
 | kbd:[C-c M-t v]
-| Toggle var tracing.
+| Toggle var tracing. If invoked with a prefix argument it inverts the value of `cider-prompt-for-symbol`.
 
 | `cider-toggle-trace-ns`
 | kbd:[C-c M-t n]
 | Toggle namespace tracing.
 
 | `cider-undef`
 | kbd:[C-c C-u]
-| Undefine a symbol. If invoked with a prefix argument, or no symbol is found at point, prompt for a symbol.
+| Undefine a symbol. If invoked with a prefix argument it inverts the value of `cider-prompt-for-symbol`.
 
 | `cider-test-run-test`
 | kbd:[C-c C-t t] +
@@ -253,7 +253,7 @@ kbd:[C-c C-t C-b]
 
 | `cider-find-var`
 | kbd:[M-.]
-| Jump to the definition of a symbol.  If invoked with a prefix argument, or no symbol is found at point, prompt for a symbol.
+| Jump to the definition of a symbol.  If invoked with a prefix argument it inverts the value of `cider-prompt-for-symbol`.
 
 | `cider-find-dwim-at-mouse`
 | kbd:[mouse-5] or kbd:[mouse-9]