Skip to content

Commit a092c74

Browse files
committed
Remove clojure-enable-cider and clojure-disable-cider
1 parent b983db6 commit a092c74

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ On by default, when `nil` don't automatically enable `cider-mode` in all Clojure
7575
to avoid conflicts with <kbd>C-g</kbd>.
7676
* [#1088](https://github.com/clojure-emacs/cider/issues/1088): Kill the
7777
source-tracking evaluation hack as it wasn't compatible with ClojureScript.
78+
* Removed `clojure-enable-cider` and `clojure-disable-cider`.
7879

7980
### Bugs fixed
8081

cider-interaction.el

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1748,17 +1748,6 @@ If invoked with a prefix ARG eval the expression after inserting it."
17481748
(interactive)
17491749
(message (read (nrepl-dict-get (nrepl-sync-request:eval "\"PONG\"") "value"))))
17501750

1751-
(defun clojure-enable-cider ()
1752-
"Turn on CIDER mode (see command `cider-mode').
1753-
Useful in hooks."
1754-
(cider-mode 1)
1755-
(setq next-error-function #'cider-jump-to-compilation-error))
1756-
1757-
(defun clojure-disable-cider ()
1758-
"Turn off CIDER mode (see command `cider-mode').
1759-
Useful in hooks."
1760-
(cider-mode -1))
1761-
17621751
(defun cider-connected-p ()
17631752
"Return t if CIDER is currently connected, nil otherwise."
17641753
(nrepl-current-connection-buffer 'no-error))
@@ -1773,18 +1762,18 @@ an error is signaled."
17731762
"Enable CIDER's minor mode on existing Clojure buffers.
17741763
See command `cider-mode'."
17751764
(interactive)
1776-
(add-hook 'clojure-mode-hook #'clojure-enable-cider)
1765+
(add-hook 'clojure-mode-hook #'cider-mode)
17771766
(dolist (buffer (cider-util--clojure-buffers))
17781767
(with-current-buffer buffer
1779-
(clojure-enable-cider))))
1768+
(cider-mode +1))))
17801769

17811770
(defun cider-disable-on-existing-clojure-buffers ()
17821771
"Disable `cider-mode' on existing Clojure buffers.
17831772
See command `cider-mode'."
17841773
(interactive)
17851774
(dolist (buffer (cider-util--clojure-buffers))
17861775
(with-current-buffer buffer
1787-
(clojure-disable-cider))))
1776+
(cider-mode -1))))
17881777

17891778
(defun cider-possibly-disable-on-existing-clojure-buffers ()
17901779
"If not connected, disable `cider-mode' on existing Clojure buffers."

cider-macroexpansion.el

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ and point is placed after the expanded form."
167167
"Create a new macroexpansion buffer."
168168
(with-current-buffer (cider-popup-buffer cider-macroexpansion-buffer t)
169169
(clojure-mode)
170-
(clojure-disable-cider)
170+
(cider-mode -1)
171171
(cider-macroexpansion-mode 1)
172172
(current-buffer)))
173173

cider-mode.el

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,8 @@ entirely."
175175
(cider-eldoc-setup)
176176
(make-local-variable 'completion-at-point-functions)
177177
(add-to-list 'completion-at-point-functions
178-
#'cider-complete-at-point))
178+
#'cider-complete-at-point)
179+
(setq next-error-function #'cider-jump-to-compilation-error))
179180

180181
(provide 'cider-mode)
181182

0 commit comments

Comments
 (0)