Drop support for Nashorn

Author: bbatsov

CHANGELOG.md

@@ -19,6 +19,7 @@
 
 * [#2826](https://github.com/clojure-emacs/cider/pull/2826): Add support for symbols with quotes and resolving of ns-aliased keywords in `cider-symbol-at-point`.
 * [#2617](https://github.com/clojure-emacs/cider/pull/2617): Add menu bar entry for `Insert last sexp in REPL`.
+* Removed support for the Nashorn ClojureScript REPL. (it was removed upstream in ClojureScript)
 
 ### Bugs fixed
 

cider-connection.el

@@ -556,7 +556,7 @@ The following formats can be used in TEMPLATE string:
   %j - short project name, or directory name if no project
   %J - long project name including parent dir name
   %r - REPL type (clj or cljs)
-  %S - type of the ClojureScript runtime (Nashorn, Node, Figwheel etc.)
+  %S - type of the ClojureScript runtime (Browser, Node, Figwheel etc.)
   %s - session name as defined by `cider-session-name-template'.
 
 In case some values are empty, extra separators (: and -) are automatically
@@ -620,7 +620,7 @@ Session name can be customized with `cider-session-name-template'."
 ;;; REPL Buffer Init
 
 (defvar-local cider-cljs-repl-type nil
-  "The type of the ClojureScript runtime (Nashorn, Node etc.)")
+  "The type of the ClojureScript runtime (Browser, Node, Figwheel, etc.)")
 
 (defvar-local cider-repl-type nil
   "The type of this REPL buffer, usually either clj or cljs.")

cider.el

@@ -659,10 +659,6 @@ Generally you should not disable this unless you run into some faulty check."
   (unless (cider-library-present-p "cider.piggieback")
     (user-error "Piggieback 0.4.x (aka cider/piggieback) is not available.  See https://docs.cider.mx/cider/basics/clojurescript for details")))
 
-(defun cider-check-nashorn-requirements ()
-  "Check whether we can start a Nashorn ClojureScript REPL."
-  (cider-verify-piggieback-is-present))
-
 (defun cider-check-node-requirements ()
   "Check whether we can start a Node ClojureScript REPL."
   (cider-verify-piggieback-is-present)
@@ -814,9 +810,7 @@ The supplied string will be wrapped in a do form if needed."
        (format "(do %s)" form)))))
 
 (defvar cider-cljs-repl-types
-  '((nashorn "(do (require 'cljs.repl.nashorn) (cider.piggieback/cljs-repl (cljs.repl.nashorn/repl-env)))"
-             cider-check-nashorn-requirements)
-    (figwheel "(do (require 'figwheel-sidecar.repl-api) (figwheel-sidecar.repl-api/start-figwheel!) (figwheel-sidecar.repl-api/cljs-repl))"
+  '((figwheel "(do (require 'figwheel-sidecar.repl-api) (figwheel-sidecar.repl-api/start-figwheel!) (figwheel-sidecar.repl-api/cljs-repl))"
               cider-check-figwheel-requirements)
     (figwheel-main cider-figwheel-main-init-form cider-check-figwheel-main-requirements)
     (figwheel-connected "(figwheel-sidecar.repl-api/cljs-repl)"
@@ -865,9 +859,9 @@ This affects commands like `cider-jack-in-cljs'.  Generally it's
 intended to be set via .dir-locals.el for individual projects, as its
 relatively unlikely you'd like to use the same type of REPL in each project
 you're working on."
-  :type '(choice (const :tag "Nashorn"  nashorn)
-                 (const :tag "Figwheel" figwheel)
+  :type '(choice (const :tag "Figwheel" figwheel)
                  (const :tag "Figwheel Main" figwheel-main)
+                 (const :tag "Browser"  browser)
                  (const :tag "Node"     node)
                  (const :tag "Weasel"   weasel)
                  (const :tag "Boot"     boot)

doc/modules/ROOT/pages/cljs/configuration.adoc

@@ -26,11 +26,11 @@ NOTE: Modifying this variable will affect all ClojureScript REPL types.
 
 If you frequently use the same ClojureScript REPL, you can set
 `cider-default-cljs-repl` and CIDER will skip the prompt and use this
-instead. For example, the following will make Nashorn the default:
+instead. For example, the following will make Node.js the default:
 
 [source,lisp]
 ----
-(setq cider-default-cljs-repl 'nashorn)
+(setq cider-default-cljs-repl 'node)
 ----
 
 == Defining Custom ClojureScript REPL Types

doc/modules/ROOT/pages/cljs/overview.adoc

@@ -7,7 +7,7 @@ debugger are currently Clojure-only features.
 
 Unlike the Clojure ecosystem that is dominated by a single REPL, the
 ClojureScript ecosystem has a number of different choices for REPLs
-(e.g. `nashorn`, `node`, `weasel`, `figwheel` and `shadow-cljs`). You'll have to
+(e.g. `browser`, `node`, `weasel`, `figwheel` and `shadow-cljs`). You'll have to
 decide which one you want to run and how you want CIDER to interact with it.
 
 In this section we'll take a look at how ClojureScript support is implemented in CIDER,

doc/modules/ROOT/pages/cljs/up_and_running.adoc

@@ -77,8 +77,8 @@ require you to configure additional setup. For example, you'll need to
 have Node.js installed to be able to start a Node REPL.
 
 TIP: The only ClojureScript REPL type that doesn't require any additional
-setup is the Nashorn REPL. Unfortunately it's going to be removed in
-future versions of the JDK.
+setup is the browser REPL. To use the Node.js REPL you'll need to install
+Node.js.
 
 == Working with `.cljc` files