Skip to content

Commit b6595c6

Browse files
committed
Remove the Rhino stuff
It's no longer supported upstream by piggieback.
1 parent 0affa7d commit b6595c6

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@
4141
* [#2202](https://github.com/clojure-emacs/cider/issues/2202): Don't try to start a ClojureScript REPL before checking whether that's possible or not.
4242
* [orchard#24](https://github.com/clojure-emacs/orchard/pull/24): Inspector now separately renders clickable keys and values when inspecting maps.
4343
* [orchard#24](https://github.com/clojure-emacs/orchard/pull/24): Inspector now remembers the current page of each level of nesting when navigating big and nested collection.
44+
* Require piggieback 0.3 or newer.
45+
* Drops support for Rhino in favour of the modern Nashorn.
4446

4547
## 0.16.0 (2017-12-28)
4648

cider.el

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -670,9 +670,7 @@ The supplied string will be wrapped in a do form if needed."
670670
(format "(do %s)" form))))
671671

672672
(defvar cider-cljs-repl-types
673-
'(("Rhino" "(cemerick.piggieback/cljs-repl (cljs.repl.rhino/repl-env))"
674-
nil)
675-
("Nashorn" "(cemerick.piggieback/cljs-repl (cljs.repl.nashorn/repl-env))"
673+
'(("Nashorn" "(cemerick.piggieback/cljs-repl (cljs.repl.nashorn/repl-env))"
676674
cider-check-nashorn-requirements)
677675
("Figwheel" "(do (require 'figwheel-sidecar.repl-api) (figwheel-sidecar.repl-api/start-figwheel!) (figwheel-sidecar.repl-api/cljs-repl))"
678676
cider-check-figwheel-requirements)
@@ -718,8 +716,7 @@ This affects commands like `cider-jack-in-clojurescript'. Generally it's
718716
intended to be set via .dir-locals.el for individual projects, as its
719717
relatively unlikely you'd like to use the same type of REPL in each project
720718
you're working on."
721-
:type '(choice (const "Rhino")
722-
(const "Nashorn")
719+
:type '(choice (const "Nashorn")
723720
(const "Figwheel")
724721
(const "Node")
725722
(const "Weasel")

0 commit comments

Comments
 (0)