Skip to content

Commit c077b4c

Browse files
committed
Improve instructions for updating nREPL
1 parent ef72605 commit c077b4c

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

cider-connection.el

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ available) and the matching REPL buffer."
6666
:safe #'booleanp
6767
:package-version '(cider . "0.9.0"))
6868

69-
(defconst cider-required-nrepl-version "0.4.4"
69+
(defconst cider-required-nrepl-version "0.6.0"
7070
"The minimum nREPL version that's known to work properly with CIDER.")
7171

7272

@@ -191,11 +191,11 @@ FORMAT is a format string to compile with ARGS and display on the REPL."
191191
"Check whether we're using a compatible nREPL version."
192192
(if-let* ((nrepl-version (cider--nrepl-version)))
193193
(when (version< nrepl-version cider-required-nrepl-version)
194-
(cider-emit-manual-warning "troubleshooting.html#_warning_saying_you_have_to_use_nrepl_0_4_4"
194+
(cider-emit-manual-warning "troubleshooting.html#_warning_saying_you_have_to_use_newer_nrepl"
195195
"CIDER requires nREPL %s (or newer) to work properly"
196196
cider-required-nrepl-version))
197-
(cider-emit-manual-warning "troubleshooting.html#_warning_saying_you_have_to_use_nrepl_0_4_4"
198-
"Can't determine nREPL's version.\nPlease, update nREPL to %s."
197+
(cider-emit-manual-warning "troubleshooting.html#_warning_saying_you_have_to_use_newer_nrepl"
198+
"Can't determine nREPL's version.\nPlease, update nREPL to %s (or newer)."
199199
cider-required-nrepl-version)))
200200

201201
(defvar cider-minimum-clojure-version)

doc/modules/ROOT/pages/troubleshooting.adoc

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,18 +96,21 @@ This will bring up a backtrace with the entire function stack, including
9696
function arguments. So you should be able to figure out what's going on (or at
9797
least what's being required).
9898

99-
=== Warning saying you have to use nREPL 0.4.4+
99+
=== Warning saying you have to use newer nREPL
100100

101-
CIDER currently requires at least nREPL 0.4.4 to work properly (there were some
102-
nasty bugs in older version and no support for tracking where some var was
103-
defined in the source code). Leiningen users can add this to their
104-
`profiles.clj` to force the proper dependency:
101+
CIDER currently requires at least nREPL 0.6 to work properly. As nREPL comes
102+
bundled with Leiningen and Boot, from time to time you might have to override the
103+
version supplied by them (e.g. if you're forced to use an older version of
104+
Leiningen or there's no release bundling the required nREPL version yet). Leiningen
105+
users can add this to their `profiles.clj` to force the proper dependency:
105106

106107
[source,clojure]
107108
----
108109
{:repl {:dependencies [[nrepl/nrepl "x.y.z"]]}}
109110
----
110111

112+
The procedure is pretty similar for Boot.
113+
111114
IMPORTANT: Make sure you add the newer nREPL dependency to the `:dependencies` key instead
112115
of `:plugins` (where `cider-nrepl` Lein plugin resides). That's a pretty common
113116
mistake.

0 commit comments

Comments
 (0)