Enable cider-stacktrace-mode before displaying the error buffer

Fixes #946.

Author: cichli

CHANGELOG.md

@@ -88,6 +88,7 @@ when in buffer that's not visiting a file (e.g. a REPL buffer).
 * [#1033](https://github.com/clojure-emacs/cider/issues/1033): Removed erroneous underlining from stacktrace frames and disabled frame filters in the error buffer.
 * The error buffer no longer pops up when there is no error to display.
 * `cider-find-resource` now correctly throws an error when no path is provided.
+* [#946](https://github.com/clojure-emacs/cider/issues/946): `cider-stacktrace-mode` is now enabled before the error buffer is displayed.
 
 ## 0.8.2 / 2014-12-21
 

cider-interaction.el

@@ -1241,17 +1241,17 @@ currently selected buffer."
               '(t always only-in-repl)
             '(t always except-in-repl)))))
 
-(defun cider-new-error-buffer ()
-  "Return an empty error buffer, possibly displaying and/or selecting it.
+(defun cider-new-error-buffer (&optional mode)
+  "Return an empty error buffer using MODE.
 
 When deciding whether to display the buffer, takes into account both the
 value of `cider-show-error-buffer' and the currently selected buffer.
 
 When deciding whether to select the buffer, takes into account the value of
 `cider-auto-select-error-buffer'."
   (if (cider--show-error-buffer-p)
-      (cider-popup-buffer cider-error-buffer cider-auto-select-error-buffer)
-    (cider-make-popup-buffer cider-error-buffer)))
+      (cider-popup-buffer cider-error-buffer cider-auto-select-error-buffer mode)
+    (cider-make-popup-buffer cider-error-buffer mode)))
 
 (defun cider--handle-err-eval-response (response)
   "Render eval RESPONSE into a new error buffer.
@@ -1275,7 +1275,7 @@ Uses the value of the `out' slot in RESPONSE."
 (defun cider--render-stacktrace-causes (causes)
   "If CAUSES is non-nil, render its contents into a new error buffer."
   (when causes
-    (let ((error-buffer (cider-new-error-buffer)))
+    (let ((error-buffer (cider-new-error-buffer #'cider-stacktrace-mode)))
       (cider-stacktrace-render error-buffer (reverse causes)))))
 
 (defun cider--handle-stacktrace-response (response causes)

cider-stacktrace.el

@@ -552,7 +552,6 @@ This associates text properties to enable filtering and source navigation."
 (defun cider-stacktrace-render (buffer causes)
   "Emit into BUFFER useful stacktrace information for the CAUSES."
   (with-current-buffer buffer
-    (cider-stacktrace-mode)
     (let ((inhibit-read-only t))
       (erase-buffer)
       (newline)