Skip to content

Commit fe397a5

Browse files
authored
Fix shell quoting in Gradle tests (#3229)
Needed for Windows.
1 parent 19124d4 commit fe397a5

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

test/cider-tests.el

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,12 @@
129129
:to-equal ""))
130130
(it "returns a single middleware param if one passed"
131131
(expect (cider--gradle-middleware-params '("my-ns/my-middleware"))
132-
:to-equal "--middleware\\=my-ns/my-middleware"))
132+
:to-equal (shell-quote-argument "--middleware=my-ns/my-middleware")))
133133
(it "returrns multiple middleware params, space-separated, if multiple passed"
134134
(expect (cider--gradle-middleware-params '("my-ns/my-middleware" "other-ns/other-middleware"))
135-
:to-equal "--middleware\\=my-ns/my-middleware --middleware\\=other-ns/other-middleware")))
135+
:to-equal (concat (shell-quote-argument "--middleware=my-ns/my-middleware")
136+
" "
137+
(shell-quote-argument "--middleware=other-ns/other-middleware")))))
136138

137139
(describe "cider-inject-jack-in-dependencies"
138140
:var (cider-jack-in-dependencies cider-jack-in-nrepl-middlewares cider-jack-in-lein-plugins cider-jack-in-dependencies-exclusions)
@@ -574,7 +576,7 @@
574576
(spy-on 'locate-file :and-return-value "/project/command")
575577
(spy-on 'executable-find :and-return-value "/bin/command")
576578
(expect (cider--resolve-project-command "command")
577-
:to-equal "/bin/command")))
579+
:to-equal (shell-quote-argument "/bin/command"))))
578580

579581
(provide 'cider-tests)
580582

0 commit comments

Comments
 (0)