Instrumented face is not cleared in the REPL when you remove instrumentation

[bbatsov]

That's a relatively small bug, but it's also kind of annoying that the special font-locking never goes away from functions that were already evaluated in the REPL.

Expected behavior

After removing debug instrumentation this should affect functions that were already executed in the REPL.

Actual behavior

This doesn't happen.

Steps to reproduce the problem

1. Instrument some function.
2. Execute it in the REPL
3. De-instrument the function.

Environment & Version information

CIDER version information

; CIDER 0.11.0snapshot (package: 20151112.1551) (Clojure 1.7.0, nREPL 0.2.12)

Emacs version

24.5

Operating system

OS X El Capitan

[Malabarba]

Hm. I see why that would happen, but I don't think it has an easy fix. The REPL specifically avoids font locking stuff above the most recent prompt. So any previous inputs are sort of frozen in time. :-)

[bbatsov]

I actually think there's an easy fix - we can just strip such faces before freezing the input.

[Malabarba]

Sounds reasonable. 👍

[xiongtx]

@Malabarba Any 🎲 you can take a look at this?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

[bbatsov]

Drive-by triage: the mechanism that caused this in 2016 doesn't appear to be in the current codebase. cider-debug.el applies debug-related faces only via overlays (cider-debug-code-overlay-face on category 'debug-code, and the prompt face on the active debug-prompt overlay), both removed by cider--debug-remove-overlays when debug mode exits. There's no text-property-based debug face on REPL input that would persist into frozen transcript history.

Can anyone still reproduce on current master? A screenshot or short recipe would help. Otherwise this is a candidate for closing as "cannot reproduce".

[bbatsov]

No repro has surfaced and the 2016-era mechanism behind this isn't in the current codebase - debug faces are applied via overlays and cleared by cider--debug-remove-overlays on exit, so they don't persist into the REPL transcript. Closing as cannot-reproduce; happy to reopen with a recipe on current master.